Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:optimize neo4j cypher statement #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KKenny0
Copy link

@KKenny0 KKenny0 commented Oct 23, 2024

Pre-Checklist

  • I have read through the CONTRIBUTING.md documentation.
  • I have tested the new statement.

Description

I was prompted by the Syntex Error when I was using the original statement in my environment: neo4j = = 4.4.38, GDS = 2.6.2, so I tried to optimize the original statement to make the program work.

Signed-off-by: Kennywu <jdlow@live.cn>
@gusye1234
Copy link
Owner

I was testing neo4j with kernel version "5.23.0".
Did the syntax you use will cause errros in the latest version?

@KKenny0
Copy link
Author

KKenny0 commented Oct 24, 2024

I was testing neo4j with kernel version "5.23.0". Did the syntax you use will cause errros in the latest version?

Ok, I noticed that the syntax I was using was deprecated in the version 5.x. Maybe we can tweak the code so that it works for both 4.x and 5.x versions.

@gusye1234
Copy link
Owner

Maybe you can fork a neo4j version 4 storage in another file?
Seem like 4 and 5 are pretty different

@KKenny0
Copy link
Author

KKenny0 commented Oct 24, 2024

Maybe you can fork a neo4j version 4 storage in another file? Seem like 4 and 5 are pretty different

In fact, I mention this PR just to hint at potential problems. Perhaps a note in the README about neo4j version dependencies would be helpful to users.

gusye1234 added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants