Skip to content

Commit

Permalink
e2e: disable EGUpgradeTest (envoyproxy#3310)
Browse files Browse the repository at this point in the history
* chore: add ClientTimeoutTest

Signed-off-by: zirain <zirain2009@gmail.com>

* e2e: disable EGUpgradeTest

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
  • Loading branch information
zirain authored Apr 30, 2024
1 parent e14b29d commit 6b9bd19
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
5 changes: 1 addition & 4 deletions test/e2e/tests/client_timeout.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ import (
)

func init() {
// This test cause too much flakiness, so we disable it for now.
// TODO: find a better way to test client timeout.
// ConformanceTests = append(ConformanceTests, ClientTimeoutTest)
ConformanceTests = append(ConformanceTests, ClientTimeoutTest)
}

var largeSizeHeader = func() string {
Expand All @@ -35,7 +33,6 @@ var largeSizeHeader = func() string {
return b.String()
}

// nolint
var ClientTimeoutTest = suite.ConformanceTest{
ShortName: "ClientTimeout",
Description: "Test that the ClientTrafficPolicy API implementation supports client timeout",
Expand Down
1 change: 1 addition & 0 deletions test/e2e/upgrade/eg_upgrade_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ func TestEGUpgrade(t *testing.T) {
RunTest: *flags.RunTest,
SkipTests: []string{
tests.EnvoyShutdownTest.ShortName, // https://github.com/envoyproxy/gateway/issues/3262
tests.EGUpgradeTest.ShortName, // https://github.com/envoyproxy/gateway/issues/3311
},
})

Expand Down

0 comments on commit 6b9bd19

Please sign in to comment.