Skip to content

Commit

Permalink
fix api nit (envoyproxy#3497)
Browse files Browse the repository at this point in the history
Signed-off-by: zirain <zirain2009@gmail.com>
  • Loading branch information
zirain authored May 29, 2024
1 parent 44330ef commit 6f30397
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 22 deletions.
2 changes: 1 addition & 1 deletion api/v1alpha1/accesslogging_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ type OpenTelemetryEnvoyProxyAccessLog struct {
Port int32 `json:"port,omitempty"`
// BackendRefs references a Kubernetes object that represents the
// backend server to which the access log will be sent.
// Only service Kind is supported for now.
// Only Service kind is supported for now.
//
// +optional
// +kubebuilder:validation:MaxItems=1
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/envoyproxy_metric_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ type ProxyOpenTelemetrySink struct {
Port int32 `json:"port,omitempty"`
// BackendRefs references a Kubernetes object that represents the
// backend server to which the metric will be sent.
// Only service Kind is supported for now.
// Only Service kind is supported for now.
//
// +optional
// +kubebuilder:validation:MaxItems=1
Expand Down
10 changes: 6 additions & 4 deletions api/v1alpha1/ext_auth_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,14 @@ type ExtAuth struct {
type GRPCExtAuthService struct {
// BackendRef references a Kubernetes object that represents the
// backend server to which the authorization request will be sent.
// Only service Kind is supported for now.
// Only Service kind is supported for now.
//
// Deprecated: Use BackendRefs instead.
BackendRef *gwapiv1.BackendObjectReference `json:"backendRef,omitempty"`

// BackendRefs references a Kubernetes object that represents the
// backend server to which the authorization request will be sent.
// Only service Kind is supported for now.
// Only Service kind is supported for now.
//
// +optional
// +kubebuilder:validation:MaxItems=1
Expand All @@ -79,13 +80,14 @@ type GRPCExtAuthService struct {
type HTTPExtAuthService struct {
// BackendRef references a Kubernetes object that represents the
// backend server to which the authorization request will be sent.
// Only service Kind is supported for now.
// Only Service kind is supported for now.
//
// Deprecated: Use BackendRefs instead.
BackendRef *gwapiv1.BackendObjectReference `json:"backendRef,omitempty"`

// BackendRefs references a Kubernetes object that represents the
// backend server to which the authorization request will be sent.
// Only service Kind is supported for now.
// Only Service kind is supported for now.
//
// +optional
// +kubebuilder:validation:MaxItems=1
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/shared_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ type KubernetesPatchSpec struct {
// BackendRef defines how an ObjectReference that is specific to BackendRef.
type BackendRef struct {
// BackendObjectReference references a Kubernetes object that represents the backend.
// Only service Kind is supported for now.
// Only Service kind is supported for now.
gwapiv1.BackendObjectReference `json:",inline"`
}

Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/tracing_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type TracingProvider struct {
Port int32 `json:"port,omitempty"`
// BackendRefs references a Kubernetes object that represents the
// backend server to which the trace will be sent.
// Only service Kind is supported for now.
// Only Service kind is supported for now.
//
// +optional
// +kubebuilder:validation:MaxItems=1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10406,7 +10406,7 @@ spec:
description: |-
BackendRefs references a Kubernetes object that represents the
backend server to which the access log will be sent.
Only service Kind is supported for now.
Only Service kind is supported for now.
items:
description: BackendRef defines how an ObjectReference
that is specific to BackendRef.
Expand Down Expand Up @@ -10633,7 +10633,7 @@ spec:
description: |-
BackendRefs references a Kubernetes object that represents the
backend server to which the metric will be sent.
Only service Kind is supported for now.
Only Service kind is supported for now.
items:
description: BackendRef defines how an ObjectReference
that is specific to BackendRef.
Expand Down Expand Up @@ -10829,7 +10829,7 @@ spec:
description: |-
BackendRefs references a Kubernetes object that represents the
backend server to which the trace will be sent.
Only service Kind is supported for now.
Only Service kind is supported for now.
items:
description: BackendRef defines how an ObjectReference
that is specific to BackendRef.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,9 @@ spec:
description: |-
BackendRef references a Kubernetes object that represents the
backend server to which the authorization request will be sent.
Only service Kind is supported for now.
Only Service kind is supported for now.
Deprecated: Use BackendRefs instead.
properties:
group:
Expand Down Expand Up @@ -339,7 +341,7 @@ spec:
description: |-
BackendRefs references a Kubernetes object that represents the
backend server to which the authorization request will be sent.
Only service Kind is supported for now.
Only Service kind is supported for now.
items:
description: BackendRef defines how an ObjectReference that
is specific to BackendRef.
Expand Down Expand Up @@ -451,7 +453,9 @@ spec:
description: |-
BackendRef references a Kubernetes object that represents the
backend server to which the authorization request will be sent.
Only service Kind is supported for now.
Only Service kind is supported for now.
Deprecated: Use BackendRefs instead.
properties:
group:
Expand Down Expand Up @@ -531,7 +535,7 @@ spec:
description: |-
BackendRefs references a Kubernetes object that represents the
backend server to which the authorization request will be sent.
Only service Kind is supported for now.
Only Service kind is supported for now.
items:
description: BackendRef defines how an ObjectReference that
is specific to BackendRef.
Expand Down
14 changes: 7 additions & 7 deletions site/content/en/latest/api/extension_types.md
Original file line number Diff line number Diff line change
Expand Up @@ -1639,8 +1639,8 @@ _Appears in:_

| Field | Type | Required | Description |
| --- | --- | --- | --- |
| `backendRef` | _[BackendObjectReference](https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1.BackendObjectReference)_ | true | BackendRef references a Kubernetes object that represents the<br />backend server to which the authorization request will be sent.<br />Only service Kind is supported for now.<br />Deprecated: Use BackendRefs instead. |
| `backendRefs` | _[BackendRef](#backendref) array_ | false | BackendRefs references a Kubernetes object that represents the<br />backend server to which the authorization request will be sent.<br />Only service Kind is supported for now. |
| `backendRef` | _[BackendObjectReference](https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1.BackendObjectReference)_ | true | BackendRef references a Kubernetes object that represents the<br />backend server to which the authorization request will be sent.<br />Only Service kind is supported for now.<br /><br />Deprecated: Use BackendRefs instead. |
| `backendRefs` | _[BackendRef](#backendref) array_ | false | BackendRefs references a Kubernetes object that represents the<br />backend server to which the authorization request will be sent.<br />Only Service kind is supported for now. |


#### Gateway
Expand Down Expand Up @@ -1802,8 +1802,8 @@ _Appears in:_

| Field | Type | Required | Description |
| --- | --- | --- | --- |
| `backendRef` | _[BackendObjectReference](https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1.BackendObjectReference)_ | true | BackendRef references a Kubernetes object that represents the<br />backend server to which the authorization request will be sent.<br />Only service Kind is supported for now.<br />Deprecated: Use BackendRefs instead. |
| `backendRefs` | _[BackendRef](#backendref) array_ | false | BackendRefs references a Kubernetes object that represents the<br />backend server to which the authorization request will be sent.<br />Only service Kind is supported for now. |
| `backendRef` | _[BackendObjectReference](https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1.BackendObjectReference)_ | true | BackendRef references a Kubernetes object that represents the<br />backend server to which the authorization request will be sent.<br />Only Service kind is supported for now.<br /><br />Deprecated: Use BackendRefs instead. |
| `backendRefs` | _[BackendRef](#backendref) array_ | false | BackendRefs references a Kubernetes object that represents the<br />backend server to which the authorization request will be sent.<br />Only Service kind is supported for now. |
| `path` | _string_ | true | Path is the path of the HTTP External Authorization service.<br />If path is specified, the authorization request will be sent to that path,<br />or else the authorization request will be sent to the root path. |
| `headersToBackend` | _string array_ | false | HeadersToBackend are the authorization response headers that will be added<br />to the original client request before sending it to the backend server.<br />Note that coexisting headers will be overridden.<br />If not specified, no authorization response headers will be added to the<br />original client request. |

Expand Down Expand Up @@ -2412,7 +2412,7 @@ _Appears in:_
| --- | --- | --- | --- |
| `host` | _string_ | false | Host define the extension service hostname.<br />Deprecated: Use BackendRefs instead. |
| `port` | _integer_ | false | Port defines the port the extension service is exposed on.<br />Deprecated: Use BackendRefs instead. |
| `backendRefs` | _[BackendRef](#backendref) array_ | false | BackendRefs references a Kubernetes object that represents the<br />backend server to which the access log will be sent.<br />Only service Kind is supported for now. |
| `backendRefs` | _[BackendRef](#backendref) array_ | false | BackendRefs references a Kubernetes object that represents the<br />backend server to which the access log will be sent.<br />Only Service kind is supported for now. |
| `resources` | _object (keys:string, values:string)_ | false | Resources is a set of labels that describe the source of a log entry, including envoy node info.<br />It's recommended to follow [semantic conventions](https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/). |


Expand Down Expand Up @@ -2750,7 +2750,7 @@ _Appears in:_
| --- | --- | --- | --- |
| `host` | _string_ | false | Host define the service hostname.<br />Deprecated: Use BackendRefs instead. |
| `port` | _integer_ | false | Port defines the port the service is exposed on.<br />Deprecated: Use BackendRefs instead. |
| `backendRefs` | _[BackendRef](#backendref) array_ | false | BackendRefs references a Kubernetes object that represents the<br />backend server to which the metric will be sent.<br />Only service Kind is supported for now. |
| `backendRefs` | _[BackendRef](#backendref) array_ | false | BackendRefs references a Kubernetes object that represents the<br />backend server to which the metric will be sent.<br />Only Service kind is supported for now. |


#### ProxyPrometheusProvider
Expand Down Expand Up @@ -3468,7 +3468,7 @@ _Appears in:_
| `type` | _[TracingProviderType](#tracingprovidertype)_ | true | Type defines the tracing provider type.<br />EG currently only supports OpenTelemetry. |
| `host` | _string_ | false | Host define the provider service hostname.<br />Deprecated: Use BackendRefs instead. |
| `port` | _integer_ | false | Port defines the port the provider service is exposed on.<br />Deprecated: Use BackendRefs instead. |
| `backendRefs` | _[BackendRef](#backendref) array_ | false | BackendRefs references a Kubernetes object that represents the<br />backend server to which the trace will be sent.<br />Only service Kind is supported for now. |
| `backendRefs` | _[BackendRef](#backendref) array_ | false | BackendRefs references a Kubernetes object that represents the<br />backend server to which the trace will be sent.<br />Only Service kind is supported for now. |


#### TracingProviderType
Expand Down

0 comments on commit 6f30397

Please sign in to comment.