Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

add installation from source #53

Merged
merged 5 commits into from
Jul 19, 2018

Conversation

Cyberface
Copy link
Contributor

addressing issue #31

@coveralls
Copy link

coveralls commented Jul 18, 2018

Pull Request Test Coverage Report for Build 213

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.648%

Totals Coverage Status
Change from base Build 186: 0.0%
Covered Lines: 1067
Relevant Lines: 2625

💛 - Coveralls

Copy link
Collaborator

@cdcapano cdcapano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. I think we want to provide instructions both for installing a release and installing from source. So, please keep the current instructions as-is, but add another section about how to install from source into a virtualenv. Also, I would not include anything about cloning, since that is in the contributing.md. Just start with assuming someone has cloned, and instruct them to go into their cloned source code directory.

README.rst Outdated

::

pip install gwin
git clone git@github.com:gwastro/gwin.git
ccd gwin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be cd.

duncanmmacleod
duncanmmacleod previously approved these changes Jul 19, 2018
Copy link
Member

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cdcapano cdcapano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@cdcapano cdcapano merged commit 5be86c7 into gwastro:master Jul 19, 2018
@Cyberface Cyberface deleted the add-install-instructions branch July 19, 2018 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants