update time_slice documentation, add additional option for the exact … #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index identification threshold
ahnitz
commented
Feb 28, 2024
| # to be some epsilon different in floating point value. | ||
| # (2) identify if we intended the start / end to be at an exact sample | ||
| # based on identifying only a trivial difference. | ||
| if exact_indices_threshold: |
There was a problem hiding this comment.
Here's a further explainer why this is needed. One might ask, why not just use the 'nearest' mode. Is that not the same? This block is primarily useful when doing the 'floor' rounding. You don't want it to accidentally round down say a value of 3.9999999 to the previous sample if the difference was just floating point error. If you do then depending on the situation you might get a different length in the same situation. This is intended to make it more robust against this scenario.
|
Beyond the bunch of whitespace that needs removing, I'm happy with this, but I think I'd prefer Tito review this as the request for this came from him. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…index identification threshold