Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding detector class for calculating LISA projections and response function #4691

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

acorreia61201
Copy link

No description provided.

# initialize whether to use gpu; FLR has handles if this cannot be done
self.use_gpu = use_gpu

def project_wf(self, hp, hc, lamb, beta, t0=None, use_gpu=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mimic the interface here used for the ground based detectors e.g. try to make them as similar as possible. Also, we want to be a little bit future proof as we'll likely have more than just the faslisa implementation and so will want to be able to switch between approximations / implementations of the response.

@acorreia61201
Copy link
Author

The LISA_detector class in my most recent commit should be sufficient for calculating LISA TDI channels from radiation frame PyCBC waveforms. I am able to replicate the results from the FastLISAResponse tutorial (shown here), with additional functionality for inputting reference times. By default, the TDI channels are calculated using lisatools.detector.ESAOrbits (a simulated realistic orbital file), but orbital information can be input using the Orbits base class in LISA Analysis Tools. All modifications use the most recent versions of FastLISAResponse (ver. 1.0.5) and LISA Analysis Tools.

One pending issue regards the usage of Orbits.configure, which will throw an error with the most recent version of LISA Analysis Tools. I have submitted a pull request to that repository that should solve the issue, but I am still awaiting a response from their development team. Additionally, I haven't been able to conduct timing tests on GPUs, as the most recent version of FastLISAResponse cannot be built with GPU support.

@acorreia61201 acorreia61201 marked this pull request as ready for review July 11, 2024 20:50
@ahnitz
Copy link
Member

ahnitz commented Jul 11, 2024

@acorreia61201 You'll want to rebase this PR, get the unittest to pass with your PR, and then demonstrate how this compares to say calling BBHx directly. E.g. can you post an example that reproduces BBHx output but using this class and say starting from IMRPhenomD?

@WuShichao
Copy link
Contributor

WuShichao commented Jul 12, 2024

@acorreia61201 Can you do this test: from the typical parameter space (prior) of SMBHB and stellar-mass BBH to compute the overlap between BBHx plugin and this PR? Let's do 1000 draw and plot histogram of overlap (not the match).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants