pycbc_test_suite to be able to run from anywhere within the git repo #4774
Conversation
GarethCabournDavies
changed the title
tools/pycbc_test_suite.sh
Outdated
| @@ -7,14 +7,18 @@ echo -e "\\n>> [`date`] Python Major Version:" $PYTHON_VERSION | |||
| PYTHON_MINOR_VERSION=`python -c 'import sys; print(sys.version_info.minor)'` | |||
| echo -e "\\n>> [`date`] Python Minor Version:" $PYTHON_MINOR_VERSION | |||
|
|
|||
| # This will work from anywhere within the pycbc directory | |||
| PYCBC_BASE_DIR=`git rev-parse --show-toplevel` | |||
There was a problem hiding this comment.
I think there are problems if we assume git access in certain circumstances (e.g. it will make it hard to integrate into conda's testing if we want to improve that). Can we get this without that?
I think one can do this because the script can know what directly it exists in, no?
There was a problem hiding this comment.
I guess a clarification is needed. Do you want to be able to move the test script to any folder or to run the test script from a different folder? I guess my suggestion wouldn't solve the former.
There was a problem hiding this comment.
I think run from any folder - the git problem raised makes sense, so I will look at that
There was a problem hiding this comment.
I think this will work now
|
poke on the re-review here |
|
@GarethCabournDavies You'll just have to rebase to pick up the new required tests. |
Add a base directory location - the base directory of the repo - to the pycbc_test_suite bash script, so that it can be run from any directory within the repo.
Motivation
Solve #2639