Use HFile instead of h5py.File in most places #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I haven't touched |
GarethCabournDavies
changed the title
|
I have also avoided live (due to efficiency worries) and inference, so as not to interfere with the h5py.File wrapper used there |
GarethCabournDavies
force-pushed
the
use_hfile
branch
from
8193f25
to
f9e6d03
Compare
GarethCabournDavies
force-pushed
the
use_hfile
branch
from
f9e6d03
to
a6b54b6
Compare
ahnitz
approved these changes
Jul 4, 2024
yi-fan-wang
pushed a commit
to yi-fan-wang/pycbc
that referenced
this pull request
Jul 15, 2024
* Move to HFile in pycbc_add_statmap * Move to HFile in pycbc_apply_rerank * update all-sky psd code * Move pycbc_coinc_(findtrigs,hdfinjfine,mergetrigs) to HFile * More places with HFile * More moves * Use HFile in more places * Use HFile in more places * Use HFile in more places * Use HFile in more places * Use HFile in more places * Use HFile rather than h5py.File in bank * move live executables to use HFile * Use HFile in live examples * Move minifollowups to use HFile * Move populations to use HFile * Move banksim codes to use HFile * Start to move plotting codes to use HFile * Finish moving plotting codes to use HFile * Move scripts in /bin/ to use HFile * Move bin/workflow_comparisons/offline_search codes to use HFile * Use HFile in pycbc/events * Moving more parts of pycbc/ to use HFile * Use HFile for other things in pycbc/io/hdf * Use HFile in pygrb codes * Revert "Use HFile in pycbc/events" This reverts commit 99dce9d. * Missed removal of imports * Remove HFile from types/array * Remove HFile from pycbc/types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pycbc.io.hdf's HFile class rather than h5py.File directly so that we can make changes to the functionality.
For example checksumming, version information, and anything else we may want
Standard information about the request
This is a change to utilise potential future features
This change touches everywhere in the code, but affects nothing
This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Contents
Not quite find-and-replace, but update everywhere which uses h5py.File to pycbc.io.HFile
Links to any issues or associated PRs
#1525 #4768
Testing
Broadly, this should be checked by the CI running
--helpfor all executables