Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit make banksim to allow external injection file #4808

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

divyajyoti09
Copy link
Contributor

Standard information about the request

This is a: new feature

This change affects: pycbc_make_banksim function

This change changes: documentation, banksim generator

Motivation

At the moment, only lalapps_inspinj function is allowed for creating injection file through the workflow generator pycbc_make_banksim. With this update, an externally created injection file can also be called.

Contents

The code allows for option to use inj.xml provided by user if the user chooses [external_injection] section instead of [inspinj] in the config file.

It also indicates the same in the documentation text.

Testing performed

I have tested it by generating the workflow using inj.xml generated by pycbc_create_injections. It works fine.

  • [ x ] The author of this pull request confirms they will adhere to the code of conduct

if inj_file_path == "inj.xml":
pass
else:
os.system("cp {} inj.xml".format(inj_file_path))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably shutil instead of a system command, otherwise this seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants