PyGRB: Propagating slide_id information across postprocessing plotting scripts #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the option to feed a pyplot figure object to ease debugging
load_triggers: Adding the capability to select triggers with certain slide_id
pycbc_pygrb_plot_snr_timeseries: propagating the slide_id functionalities across plotting scripts. We only want to show slide_id=0 in this plots
Update pycbc_pygrb_plot_chisq_veto: propagating slide_id functionalities across plotting scripts. Here we only want to display slide_id=0
pycbc_pygrb_plot_coh_ifosnr: propagating slide_id functionalities, here we only want to display slide_id=0
pycbc_pygrb_plot_null_stats: propagating slide_id information, here we only want to display slide_id=0
1 task
Minor fixes to satisfy codeclimate
pannarale
requested changes
Jul 21, 2024
sebastiangomezlopez
changed the title
pannarale
requested changes
Jul 22, 2024
pannarale
requested changes
Jul 22, 2024
pannarale
requested changes
Jul 23, 2024
pannarale
previously requested changes
Jul 26, 2024
Co-authored-by: Francesco Pannarale <francesco.pannarale@ligo.org>
titodalcanton
approved these changes
Jul 26, 2024
titodalcanton
dismissed
pannarale’s stale review
Request satisfied by latest commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a new feature that propagates slide_id information across some PyGRB's plotting scripts. In particular it implements a new way of displaying triggers from a specific slide_id.
Currently some PyGRB plots are overpopulated with the addition of timeslides in recent runs. For example, the following plot shows the background triggers obtained from zerlolag data + all timeslides (blue crosses), and just zerolag data, i.e.
slide_id=0(black crosses) around GW170817This change affects: PyGRB
pycbc/bin/pycbc_pygrb_plot_snr_timeseries
pycbc/bin/pycbc_pygrb_plot_coh_ifo_snr
pycbc/bin/pycbc_pygrb_plot_null_stats
pycbc/bin/pycbc_pygrb_plot_chisq_veto
pycbc/results/pygrb_plotting_utils.py
pycbc/results/pygrb_postprocessing_utils.py