Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran black on pycbc_pygrb_pp_workflow and then renamed it pycbc_pygrb_… #4906

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

pannarale
Copy link
Contributor

This PR is the 6th and final PR in a series opened by #4891.

It is a mild cleanup operation for PyGRB code.

black --skip-string-normalization --line-length 79 was run on pycbc_pygrb_pp_workflow and this script was then renamed pycbc_pygrb_results_workflow for consistency with the workflow function setup_pygrb_results_workflow that handles it upon generating a PyGRB workflow. git grep pycbc_pygrb_pp_workflow then showed other places where renaming the script was necessary.

It should now be possible to produce a full results webpage as in this example from master. Other collaborators will be asked to try doing this.

  • The author of this pull request confirms they will adhere to the code of conduct

…results_workflow for consistency with the workflow function setup_pygrb_results_workflow
@pannarale pannarale added the PyGRB PyGRB development label Oct 10, 2024
@pannarale pannarale requested a review from spxiwh October 10, 2024 12:43
@pannarale pannarale self-assigned this Oct 10, 2024
Copy link
Contributor

@spxiwh spxiwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pannarale pannarale merged commit e86c213 into gwastro:master Oct 11, 2024
30 checks passed
@pannarale pannarale deleted the pygrb_wflow branch October 11, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants