Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SFE kernel patch and move wireguard and update kernel version to broken #25

Open
wants to merge 2 commits into
base: lede-17.01
Choose a base branch
from

Conversation

juppin
Copy link

@juppin juppin commented Mar 18, 2018

Firstly, thanks for your great work on this patches.

Sadly i had three errors while building with latest 17.01 branch and your patches.

I had removed kernel version and wireguard patch to solve the first two errors while running patch_LEDE.sh.

The next and last error is because of an additional comment in net/netfilter/nf_conntrack_ecache.c.
This should fix this errors.

Due to i'm not interested in wireguard, i did not look in this issue. But at the path for patching, there are no files.

The kernel version patch is totally unneeded. Didn't know why this should be needed.

Greets

@bladeoner
Copy link

bladeoner commented Apr 21, 2018

I tried your patch but with the latest build of 17.01.4 I get the same error message as in:
#23

@juppin
Copy link
Author

juppin commented Apr 21, 2018

If you only want shortcut-fe, you could use the patch in my repos under folder patch...
For 17.01: https://github.com/juppin/openwrt_custom_builds_17.01
For trunk (kernel 4.9): https://github.com/juppin/openwrt_custom_builds_trunk

Use the shortcut-fe patch:

cd openwrt-src
patch -p1 < ../666_shortcut-fe-X.patch
make menuconfig (select shortcut-fe and fast-classifier)
make defconfig
make download && make -j4

@bladeoner
Copy link

bladeoner commented Apr 21, 2018

Ok thank you, what I am trying to accomplish is the latest 17.01 build (trunk) with the following packages:

  • LuCI
  • Mini UPnP
  • SQM
  • Shortcut-FE

I will test your patch.

@bladeoner
Copy link

I got a question about your patch, is it compatible with sqm?

Did you try gwlim's patch and test if there is a difference in throughput?

What I was reading in the thread in the LEDE forum is that gwlim's patch is also doing some mips optimization but the patch is not compatible with sqm.

@juppin
Copy link
Author

juppin commented Apr 27, 2018

Without sqm the throughput is almost the same over lan as with gwlim´s patchset.
SQM should work with shortcut-fe as it only bypass some network hooks related with iptables and not the full linux network stack. Therefore packages pass qdisc...

The patch file from my repo is only a copy of dissents not accepted pull request on lede-project...

I think shortcut-fe from gwlim and from dissent are almost the same...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants