Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Duplicate template generated when cartesian_control = True #384

Closed
liunelson opened this issue Oct 9, 2024 · 1 comment · Fixed by #385
Closed

[BUG] Duplicate template generated when cartesian_control = True #384

liunelson opened this issue Oct 9, 2024 · 1 comment · Fixed by #385

Comments

@liunelson
Copy link

I have this model:
mathml model.json

I run this stratification:

model = stratify(
    template_model=model,
    key= "vaccination status",
    strata=['O', 'VR', 'V'],
    structure= [['O', 'V'], ['V', 'VR']],
    directed=True,
    cartesian_control=False,
    modify_names=True,
    concepts_to_stratify=['S'], #If none given, will stratify all concepts.
    params_to_stratify= ['η', 'β'], #If none given, will stratify all parameters.
    param_renaming_uses_strata_names = True
)

When cartesian_control = True, all templates that had S has a subject concept got triplicated (i.e. identical rate laws). Since all the controllers of those templates (I, A) are not stratified, I had expected that cartesian_control = True, False would do nothing. What is the intended behaviour?

@liunelson
Copy link
Author

This can be replicated with a simple SIR model where I stratify it over n groups by just S and either cartesian_control = True or cartesian_control = False. In the former case, I get an extra factor of n in front of the b S_* I terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant