Explicitly filter excluded controllers when considering cartesian product #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a corner case where all of the controllers of a given template are excluded from stratification but cartesian control is chosen to be True. Though stratification of these controllers didn't happen, the loop for the cartesian product still ran, creating multiple copies of the statement. This PR fixes that so that if all of the controllers are excluded then the cartesian product is not considered at all.
Fixes #384