-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mathml -> sympy conversion #188
Conversation
Tests are failing because there seems to be a problem with installing pandas. I haven't figured out why yet though, pandas is not a requirement for sbmlmath.
|
30cf70c
to
cad7684
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #188 +/- ##
==========================================
+ Coverage 77.37% 77.59% +0.22%
==========================================
Files 66 67 +1
Lines 5277 5369 +92
==========================================
+ Hits 4083 4166 +83
- Misses 1194 1203 +9
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR introduces the capability to parse sympy from mathml using the
sbmlmath
library.The core functionality is added in
mira.metamodel.io.mathml_to_expression
usingsbmlmath
'sSBMLMathMLParser
.mira/sources/askenet/petrinet.py
is updated to handle cases when sympy expression strings are missing from the incoming askenet petrinet model json. sympy expressions still have priority over mathml when both are available.Tests are added in the new file
test_io.py
.todo
Write test for the model api that tests the same as aboveImplicitly already tested in existing tests