Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in shield-trigger-iptables for ipset support #10

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

arnaudf92
Copy link

Hello,

As requested pls find the pull request for ipset support

@h0tw1r3
Copy link
Owner

h0tw1r3 commented Apr 26, 2024

Thanks for the submission, before I can review and test, please:

  • rebase on the latest shield-trigger-iptables script
  • only change what is necessary to implement ipset support,
  • ensure sync support is implemented

@arnaudf92
Copy link
Author

arnaudf92 commented Apr 26, 2024

Hello,
Ok.
Could you pls elaborate a bit more on sync feature ?
I see this is basically an "iptables check" thing. Is it just purported for pam_shield to check if a database ip is indeed present in iptables rules (or ipset) ?

EDIT : could you pls confirm that sync cmd means "check a 'database IP' and insert it as a rule/member if not exists" ?

@h0tw1r3
Copy link
Owner

h0tw1r3 commented May 13, 2024

EDIT : could you pls confirm that sync cmd means "check a 'database IP' and insert it as a rule/member if not exists" ?

That's correct.

@arnaudf92
Copy link
Author

arnaudf92 commented May 27, 2024

Hello,
I've pushed a new version of the shield-trigger-iptables script.
You can see it on the "Files changed" tab.

@arnaudf92
Copy link
Author

Hello,
I've just pushed a new version fixing lint errors

@arnaudf92
Copy link
Author

Hello,

Should be ok ("all checks have passed").

@arnaudf92
Copy link
Author

Hello,
No news since latest commit on May, 30th.
Any rework required ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants