Fix bounding box check function and add SortWrapper interface type

h39s · Oct 24, 2022 · 0e510b7 · 0e510b7
1 parent 45c8227
commit 0e510b7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/common/constants.ts b/src/common/constants.ts
@@ -55,14 +55,11 @@ export interface IFilter {
   quality: number;
 }
 
-export interface IBasicState {
+export interface IState {
   isEnabled: boolean;
   isAutoPreAmpOn: boolean;
   isGraphViewOn: boolean;
   preAmp: number;
-}
-
-export interface IState extends IBasicState {
   filters: IFilter[];
 }
 

diff --git a/src/renderer/SortWrapper.tsx b/src/renderer/SortWrapper.tsx
@@ -62,7 +62,7 @@ const isBoundingBoxDifferent = (
 
   for (let i = 0; i < keys1.length; i += 1) {
     if (
-      keys1[i] !== keys2[i] ||
+      !boundMap2[keys1[i]] ||
       boundMap1[keys1[i]].left !== boundMap2[keys1[i]].left
     ) {
       return true;
@@ -71,13 +71,16 @@ const isBoundingBoxDifferent = (
   return false;
 };
 
+interface ISortWrapper {
+  children: CustomElement[];
+  // This ref should refer to the parent html element that contains children
+  wrapperRef: RefObject<HTMLDivElement>;
+}
+
 const SortWrapper = ({
   children = [],
   wrapperRef,
-}: {
-  children: CustomElement[];
-  wrapperRef: RefObject<HTMLDivElement>;
-}): JSX.Element => {
+}: ISortWrapper): JSX.Element => {
   const [boundingBoxes, setBoundingBoxes] = useState<IBoundingBoxMap>({});
   const prevBoundingBoxesRef = useRef<IBoundingBoxMap>({});