Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed crash while fetching app version #412

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: fixed crash while fetching app version #412

wants to merge 1 commit into from

Conversation

dhruvanbhalara
Copy link
Contributor

  • check widget is mounted before updating the UI

SahSantoshh added a commit to SahSantoshh/Kharcha that referenced this pull request Dec 29, 2023
@SahSantoshh
fix: fixed crash while fetching app version
6160c8d 
- h4h13#412
@jaredkz jaredkz mentioned this pull request Mar 5, 2024
Closed
@dhruvanbhalara dhruvanbhalara force-pushed the fix/crash_while_fetching_app_version branch from 6bc8039 to 2df2344 Compare March 9, 2024 07:52
@dhruvanbhalara
Copy link
Contributor Author

hi @h4h13,
This is also ready for review.

@dhruvanbhalara dhruvanbhalara force-pushed the fix/crash_while_fetching_app_version branch from 2df2344 to 3d0079c Compare March 12, 2024 09:19
@dhruvanbhalara
refactor: update version code fetching
f4719d1 
-  it'll prevent crash while rendering UI in certain cases
@dhruvanbhalara dhruvanbhalara force-pushed the fix/crash_while_fetching_app_version branch from 3d0079c to f4719d1 Compare March 15, 2024 06:39
@h4h13
Copy link
Owner

h4h13 commented Mar 30, 2024

This widget is not compiled with clean architecture we need to make it can we abstract out else will do it revamped of this

@dhruvanbhalara
Copy link
Contributor Author

This widget is not compiled with clean architecture we need to make it can we abstract out else will do it revamped of this

can you please assist what needs to be changed?

@dhruvanbhalara
Copy link
Contributor Author

Hi @h4h13,
can you please suggest changes that need to be made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhruvanbhalara @h4h13