-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kaden's "hacker card" #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome OnBoard @ofluffydev! Everything looks good on HCB's side @hackclub/boarding-party. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the design! However, you have not selected assembly from JLCPCB, so there won't be any components installed on your board. Please check out https://github.com/hackclub/OnBoard/blob/main/docs/ordering_from_JLCPCB.md#pcb-assembly for more info.
Additionally, the src folder should also have a JSON from the schematic page, just like the PCB page.
Added those, did what you said and updated the price to match it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the delay.
Submission Checklist:
I am a current high school, middle school, or home schooled student.
I have joined the
#onboard
channel on SlackI made this board from scratch, even if I followed a tutorial
I have followed DIRECTIONS.md
onboard/projects
TEMPLATE.md
asREADME.md
(Optional) This project is from a tutorial1.
Footnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩