Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaden's "hacker card" #229

Merged
merged 20 commits into from
Oct 25, 2023
Merged

Kaden's "hacker card" #229

merged 20 commits into from
Oct 25, 2023

Conversation

ofluffydev
Copy link
Contributor

Submission Checklist:

  • I am a current high school, middle school, or home schooled student.

  • I have joined the #onboard channel on Slack

  • I made this board from scratch, even if I followed a tutorial

  • I have followed DIRECTIONS.md

    • Created a folder under onboard/projects
    • Filled out TEMPLATE.md as README.md
    • Uploaded Gerber, sources, and schematic
    • Uploaded screenshot of PCB order with all costs included
    • I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • (Optional) This project is from a tutorial1.

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

Copy link
Collaborator

@daisybanks daisybanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome OnBoard @ofluffydev! Everything looks good on HCB's side @hackclub/boarding-party. :)

Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the design! However, you have not selected assembly from JLCPCB, so there won't be any components installed on your board. Please check out https://github.com/hackclub/OnBoard/blob/main/docs/ordering_from_JLCPCB.md#pcb-assembly for more info.

Additionally, the src folder should also have a JSON from the schematic page, just like the PCB page.

@karmanyaahm karmanyaahm added the Submission New Boards! label Oct 19, 2023
@ofluffydev
Copy link
Contributor Author

Love the design! However, you have not selected assembly from JLCPCB, so there won't be any components installed on your board. Please check out https://github.com/hackclub/OnBoard/blob/main/docs/ordering_from_JLCPCB.md#pcb-assembly for more info.

Additionally, the src folder should also have a JSON from the schematic page, just like the PCB page.

Added those, did what you said and updated the price to match it.

Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay.

@karmanyaahm karmanyaahm merged commit 3fdc383 into hackclub:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submission New Boards!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants