-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kai NFC Card #317
Kai NFC Card #317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy! I'm approving your student verification :) The next step will be to wait 24-48 hours for the technical review and then your PR will be merged and you'll receive your grant! @hackclub/boarding-party
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Sorry for the delay in reviewing. You need to make a couple of small changes and then we'll be good to go
-
Please make a "src" folder in projects/[name]/, and put your project sources there. They should be two .JSON files, one from the schematic tab, one from the PCB tab.
-
Also, you need to export your schematic tab as a PDF (in the schematic tab go to File > Export > PDF), and upload that.
-
Assuming you want to keep using the ENIG finish (which then requires standard assembly), you can contact @sarthaktexas on Slack about covering the difference from the $50 provided for jams once your PR is merged.
Hi Kai! A few major things I wanted to note and flag for revision. On both the front: you have a logo and it's on the top copper layer. This means that it is currently shorting your entire design and it will not work. You can change this to "silkscreen" layer ("TopSilkLayer") so it is no longer conductive / electrical. On the back: you have the text and QR code on the bottom copper layer. While there are no traces / circuits / whatever that this is shorting, it is generally recommended to keep the area under the coil antenna clear of any copper, to avoid signal interference. You should also change the text and QR code to silkscreen. Once you're done correcting these issues, feel free to reply in the thread, or ping me on Slack (@hugo Hu) to review your new design. Thank you and good night! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi the file format looks good to me, but please do what hugo said, otherwise your card won't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PCB Routing is OK to me.
@sarthaktexas will send you an email with your grant card soon! |
Submission Checklist:
[ x] I am a current high school, middle school, or home schooled student.
[ x] I have joined the
#onboard
channel on Slack[ x] I made this board from scratch, even if I followed a tutorial
[ x] I have followed the directions in README.md
onboard/projects
TEMPLATE.md
asREADME.md
[x ] (Optional) This project is from a tutorial1.
(Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____
Footnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩