-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ari's Gadget Geocache PCB #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the idea!! Two small things, just like you uploaded a PCB_PCB....json file, can you File > Export > EasyEDA a file from the schematic tab as well and put it in src?
Also, you schematic.pdf needs to be exported from the schematic tab (the one with the circuit symbols, not PCB).
Really looking forward to your board. Also DMing you on Slack about some other details.
I deleted the PCB json and PCB schematic. I added the actual schematic pdf and json like you requested. |
Hi @AriM224 could you please actually re-attach the PCB json? I think there was a bit of miscommunication- needed the PDF + json schematics in addition to everything you had. This is so that I can quickly take a look over both schematic and your pcb routing to try and catch any mistakes. Thank you! |
Oh sorry, I didn't realize that both are needed. |
Ok, everything should be there now. As you might notice, the schematic is different than the PCB because I designed most of it in the PCB editor. @karmanyaahm said it was fine as long as I had the schematic uploaded. |
Hi! Thanks for the prompt reply. I don't see any problems with the PCB, so as long as your "in-pcb editor design" was correct, it should be OK. In the future I'd definitely recommend going through schematic just for ease of checking/routing. Want to note one thing that might be an issue: https://electronics.stackexchange.com/questions/39287/vias-directly-on-smd-pads |
I was wondering if it was ok to put vias on a pad. I guess I should have looked it up. I just fixed that, should I replace the files in this project with the updated board? thanks for the help |
Yes please. Just update the new PCB file and that should be great: ping me over slack ***@***.*** Hu) or reply to the thread when that’s done and I’ll take a quick look to make sure everything is OK!
On Jan 20, 2024, at 9:24 PM, Ari Mastor ***@***.******@***.***>> wrote:
I was wondering if it was ok to put vias on a pad. I guess I should have looked it up. I just fixed that, should I replace the files in this project with the updated board? thanks for the help
—
Reply to this email directly, view it on GitHub<#322 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQOQDMA2V2HIBO3WTOWDM73YPR36BAVCNFSM6AAAAABCC6U3X2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGQ4DCMZQG4>.
You are receiving this because you commented.Message ID: ***@***.***>
|
I updated all PCB-related files just to make sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me. I'd be wary about the placement of R11 in case it's too close to the holes on the sides. If you're getting something assembled by the fab then I'd consider moving it just to add some clearance.
I might just suggest moving it either way just so you don't need to worry about it being too close and accidentally causing a short but this depends on your application.
If you do want to move it + want a re-check, feel free to update your files again and re-request review from me so I know.
I moved R11 to a better place, definitely wouldn't want a short circuit there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me and ready to approve when everything else is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy Ari! I'm approving your student verification :) Just waiting on @karmanyaahm's review and I'll send your grant.
sounds good, thanks! |
@karmanyaahm everything looks good and files have been fixed. OK to approve? Thank you and good night! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
sent! |
Submission Checklist:
I am a current high school, middle school, or home schooled student.
I have joined the
#onboard
channel on SlackI made this board from scratch, even if I followed a tutorial
I have followed the directions in README.md
onboard/projects
TEMPLATE.md
asREADME.md
(Optional) This project is from a tutorial1.
(Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____
Footnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩