Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ari's Gadget Geocache PCB #322

Merged
merged 33 commits into from
Jan 23, 2024
Merged

Ari's Gadget Geocache PCB #322

merged 33 commits into from
Jan 23, 2024

Conversation

AriM224
Copy link
Contributor

@AriM224 AriM224 commented Jan 20, 2024

Submission Checklist:

  • I am a current high school, middle school, or home schooled student.

  • I have joined the #onboard channel on Slack

  • I made this board from scratch, even if I followed a tutorial

  • I have followed the directions in README.md

    • Created a folder under onboard/projects
    • Filled out TEMPLATE.md as README.md
    • Uploaded Gerber, sources, and schematic
    • Uploaded screenshot of PCB order with all costs included
    • I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • (Optional) This project is from a tutorial1.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

@karmanyaahm karmanyaahm added the Submission New Boards! label Jan 20, 2024
Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the idea!! Two small things, just like you uploaded a PCB_PCB....json file, can you File > Export > EasyEDA a file from the schematic tab as well and put it in src?

Also, you schematic.pdf needs to be exported from the schematic tab (the one with the circuit symbols, not PCB).

Really looking forward to your board. Also DMing you on Slack about some other details.

@AriM224
Copy link
Contributor Author

AriM224 commented Jan 20, 2024

I deleted the PCB json and PCB schematic. I added the actual schematic pdf and json like you requested.

@Hugoyhu
Copy link
Contributor

Hugoyhu commented Jan 20, 2024

Hi @AriM224 could you please actually re-attach the PCB json? I think there was a bit of miscommunication- needed the PDF + json schematics in addition to everything you had.

This is so that I can quickly take a look over both schematic and your pcb routing to try and catch any mistakes. Thank you!

@AriM224
Copy link
Contributor Author

AriM224 commented Jan 20, 2024

Oh sorry, I didn't realize that both are needed.

@AriM224
Copy link
Contributor Author

AriM224 commented Jan 20, 2024

Ok, everything should be there now. As you might notice, the schematic is different than the PCB because I designed most of it in the PCB editor. @karmanyaahm said it was fine as long as I had the schematic uploaded.

@Hugoyhu
Copy link
Contributor

Hugoyhu commented Jan 21, 2024

Hi! Thanks for the prompt reply. I don't see any problems with the PCB, so as long as your "in-pcb editor design" was correct, it should be OK. In the future I'd definitely recommend going through schematic just for ease of checking/routing.

Want to note one thing that might be an issue:
Screen Shot 2024-01-20 at 9 03 26 PM
On C1/2, R1-3 you have a via on one of the pads. I'd recommend rerouting it so that the vias are not on the SMD pad. You can route the via out until it clears the pad and then you can add the via.

https://electronics.stackexchange.com/questions/39287/vias-directly-on-smd-pads

@AriM224
Copy link
Contributor Author

AriM224 commented Jan 21, 2024

I was wondering if it was ok to put vias on a pad. I guess I should have looked it up. I just fixed that, should I replace the files in this project with the updated board? thanks for the help

@Hugoyhu
Copy link
Contributor

Hugoyhu commented Jan 21, 2024 via email

@AriM224
Copy link
Contributor Author

AriM224 commented Jan 21, 2024

I updated all PCB-related files just to make sure.

@Hugoyhu Hugoyhu self-requested a review January 21, 2024 14:39
Copy link
Contributor

@Hugoyhu Hugoyhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me. I'd be wary about the placement of R11 in case it's too close to the holes on the sides. If you're getting something assembled by the fab then I'd consider moving it just to add some clearance.

I might just suggest moving it either way just so you don't need to worry about it being too close and accidentally causing a short but this depends on your application.

If you do want to move it + want a re-check, feel free to update your files again and re-request review from me so I know.

@AriM224 AriM224 requested a review from Hugoyhu January 22, 2024 01:32
@AriM224
Copy link
Contributor Author

AriM224 commented Jan 22, 2024

I moved R11 to a better place, definitely wouldn't want a short circuit there.

Copy link
Contributor

@Hugoyhu Hugoyhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me and ready to approve when everything else is good.

Copy link
Member

@sarthaktexas sarthaktexas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy Ari! I'm approving your student verification :) Just waiting on @karmanyaahm's review and I'll send your grant.

@AriM224
Copy link
Contributor Author

AriM224 commented Jan 22, 2024

sounds good, thanks!

@Hugoyhu
Copy link
Contributor

Hugoyhu commented Jan 23, 2024

@karmanyaahm everything looks good and files have been fixed. OK to approve? Thank you and good night!

Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karmanyaahm karmanyaahm merged commit 74e643b into hackclub:main Jan 23, 2024
@sarthaktexas
Copy link
Member

sent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submission New Boards!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants