Jesse Beteas project #339
Merged
Jesse Beteas project #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I'm Orpheus Leap! Here to help you review your PR.
You can view a render of your board over on tracespace.io! Happy OnBoarding! |
karmanyaahm
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Hi Jesse! Love the idea! I sooo want to see more robots and cars built using OnBoard. Just a couple of small issues with the submission, and once you fix them we can get you your grant:
Additionally, please make a "src" folder in projects/[name]/, and put your project sources there. They should be two .JSON files, one from the schematic tab, one from the PCB tab. You already have the PCB.json file.
Also, your schematic file should be a PDF from the schematic tab (in the schematic tab go to File > Export > PDF), and upload that. Right now your PDF is from the PCB tab.
sarthaktexas
approved these changes
Feb 12, 2024
|
I fixed the problems with the submission |
karmanyaahm
approved these changes
Feb 14, 2024
|
Thank you so much! |
|
sent! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist:
[yes ] I am a current high school, middle school, or home schooled student.
[yes ] I have joined the
#onboardchannel on Slack[ yes] I made this board from scratch, even if I followed a tutorial
[ yes] I have followed the directions in README.md
onboard/projectsTEMPLATE.mdasREADME.md[no ] (Optional) This project is from a tutorial1.
[ yes] (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: 6566
Footnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩