-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jay's NFC Card #345
Jay's NFC Card #345
Conversation
Hi, I'm Orpheus Leap! Here to help you review your PR.
You can view a render of your board over on tracespace.io! Happy OnBoarding! |
Potential wire impedance issues? |
?? how do you check that? i'm new to Pcb designn sorry |
Idk, i'm not sure if wire impedance will be an issue, just writing it down so the technical reviewer(who knows way more than me) can see if it's an issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your student verification is approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR formatting looks great to me! But as bright was saying, it's possible that your antenna may or may not work given that the wires are so long. It'll very likely be fine, but if you want to be extra safe, I'd put the main IC right next to the antenna instead of far away.
Your LED, resistor, and capacitor can be wherever you'd like on the board though.
I'm going to approve it, and your grant will be sent soon, but I'd recommend making the change.
thank you! |
It needs to be on front silkscreen
…On Wed, Feb 21, 2024, 01:33 Jirayu Adisakdechakul ***@***.***> wrote:
wait, i thought they’re on the front?
***@***.*** (view on web)
<https://github.com/hackclub/OnBoard/assets/46888825/e33cdf52-af51-4575-8ca1-4996e32ff86f>
—
Reply to this email directly, view it on GitHub
<#345 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHZIPSTVYXRNTXKOC2JEANDYUWPNFAVCNFSM6AAAAABDNYOQOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGA2DQMJWGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Know you're still getting it working, but I've got ahead and issued the grant. Make sure to fix the change though so your wires will still work! |
Submission Checklist:
I am a current high school, middle school, or home schooled student.
I have joined the
#onboard
channel on SlackI made this board from scratch, even if I followed a tutorial
I have followed the directions in README.md
onboard/projects
TEMPLATE.md
asREADME.md
(Optional) This project is from a tutorial1.
(Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____
Footnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩