Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jay's NFC Card #345

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Jay's NFC Card #345

merged 6 commits into from
Feb 21, 2024

Conversation

iUnstable0
Copy link
Contributor

@iUnstable0 iUnstable0 commented Feb 18, 2024

Submission Checklist:

  • I am a current high school, middle school, or home schooled student.

  • I have joined the #onboard channel on Slack

  • I made this board from scratch, even if I followed a tutorial

  • I have followed the directions in README.md

    • Created a folder under onboard/projects
    • Filled out TEMPLATE.md as README.md
    • Uploaded Gerber, sources, and schematic
    • Uploaded screenshot of PCB order with all costs included
    • I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • (Optional) This project is from a tutorial1.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

@prophetorpheus
Copy link
Collaborator

Hi, I'm Orpheus Leap! Here to help you review your PR.

You can view a render of your board over on tracespace.io!

Happy OnBoarding!

@BrightTheBackpack
Copy link
Member

Potential wire impedance issues?

@iUnstable0
Copy link
Contributor Author

iUnstable0 commented Feb 18, 2024

?? how do you check that? i'm new to Pcb designn sorry

@BrightTheBackpack
Copy link
Member

Idk, i'm not sure if wire impedance will be an issue, just writing it down so the technical reviewer(who knows way more than me) can see if it's an issue

@karmanyaahm karmanyaahm added the Submission New Boards! label Feb 19, 2024
Copy link
Member

@maxwofford maxwofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your student verification is approved!

Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR formatting looks great to me! But as bright was saying, it's possible that your antenna may or may not work given that the wires are so long. It'll very likely be fine, but if you want to be extra safe, I'd put the main IC right next to the antenna instead of far away.

Your LED, resistor, and capacitor can be wherever you'd like on the board though.

I'm going to approve it, and your grant will be sent soon, but I'd recommend making the change.

@karmanyaahm karmanyaahm merged commit d3339bf into hackclub:main Feb 21, 2024
3 checks passed
@iUnstable0
Copy link
Contributor Author

thank you!

@karmanyaahm
Copy link
Member

Oh wait, I just saw this:
image
The squiggly designs in the back are on the copper layer, which means they will be wires. You probably want to put them in the silkscreen layer, so they're visibly printed with ink
Here, they are shorting all your wires together and so your board won't work because of that:
image
Please post in #onboard on slack if you want any clarification about this or DM me.

@iUnstable0
Copy link
Contributor Author

iUnstable0 commented Feb 21, 2024

wait, i thought they’re on the front?
CleanShot 2024-02-21 at 14 33 07@2x

CleanShot 2024-02-21 at 14 35 06@2x

@karmanyaahm
Copy link
Member

karmanyaahm commented Feb 21, 2024 via email

@maxwofford
Copy link
Member

Know you're still getting it working, but I've got ahead and issued the grant. Make sure to fix the change though so your wires will still work!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submission New Boards!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants