Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ari's Card #367

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Ari's Card #367

merged 4 commits into from
Mar 6, 2024

Conversation

ari-kl
Copy link
Contributor

@ari-kl ari-kl commented Mar 5, 2024

Submission Checklist:

  • I am a current high school, middle school, or home schooled student.

  • I have joined the #onboard channel on Slack

  • I made this board from scratch, even if I followed a tutorial

  • I have followed the directions in README.md

    • Created a folder under onboard/projects
    • Filled out TEMPLATE.md as README.md
    • Uploaded Gerber.zip and Schematic.pdf
    • Created a folder called src and uploaded design files
    • Uploaded screenshot of PCB order with all costs included
    • I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • (Optional) This project is from a tutorial1.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

@prophetorpheus
Copy link
Collaborator

prophetorpheus commented Mar 5, 2024

Hi, I'm Orpheus Leap! Here to help you review your PR.

projects/Ari's Card:

Required files

README.md A description of your project
cart.png cart.png
gerber.zip
🟨 schematic.pdf Manually check schematic.pdf
Source files - EasyEDA Found both PCB and SCH files

You can view a render of your board over on gerber.zip/2d!

Happy OnBoarding!
This bot is a simpler helper for common submission types. If there's an error with this, please point it out and someone from the OnBoard team will look at it manually.

Copy link
Member

@maxwofford maxwofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! thanks for submitting a PR! I wanted to flag that you should double check this part of the board. I can't quite tell from your traces but it seems like these lines crossing was unintentional.

Screenshot 2024-03-05 at 20 13 47

@ari-kl
Copy link
Contributor Author

ari-kl commented Mar 6, 2024

@maxwofford Thanks for catching that, I'm very new to this.

I updated the PCB (and uploaded the new files) and the line crossing should be gone now.

@maxwofford
Copy link
Member

Awesome, just issued the grant!

@maxwofford maxwofford merged commit 573fbd1 into hackclub:main Mar 6, 2024
1 check passed
@karmanyaahm karmanyaahm added the Submission New Boards! label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submission New Boards!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants