Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ankita-nfc-card #936

Merged
merged 27 commits into from
Aug 16, 2024
Merged

ankita-nfc-card #936

merged 27 commits into from
Aug 16, 2024

Conversation

eyestare
Copy link
Contributor

@eyestare eyestare commented Aug 6, 2024

Submission Checklist:

  • I am a current high school, middle school, or home schooled student.

  • I have joined the #electronics channel on Slack

  • I made this board from scratch, even if I followed a tutorial

  • I have followed the directions in README.md

    • Created a folder under onboard/projects
    • Filled out TEMPLATE.md as README.md inside your project folder
    • Uploaded gerber.zip and schematic.pdf inside your project folder
    • Created a folder called src and uploaded design files
    • Uploaded screenshot of PCB order called cart.png with all costs included
    • I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • (Optional) This project is from a tutorial1.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

@prophetorpheus
Copy link
Collaborator

prophetorpheus commented Aug 6, 2024

Hi, I'm Orpheus Leap! Here to help you review your PR.

projects/ankitas-nfc-card:

Required files

README.md A description of your project
cart.png cart.png
gerber.zip
schematic.pdf Manually check schematic.pdf
Source files - EasyEDA Found both PCB and SCH files

You can view a render of your board over on gerber.zip/2d!

Happy OnBoarding!
This bot is a simpler helper for common submission types. If there's an error with this, please point it out and someone from the OnBoard team will look at it manually.

@LimesKey LimesKey self-assigned this Aug 6, 2024
@LimesKey LimesKey self-requested a review August 6, 2024 20:07
@LimesKey LimesKey added the Submission New Boards! label Aug 6, 2024
Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eyestare,

Thanks for submitting your PCB pull request for OnBoard! However, it looks like you took a picture of the cart ordering process instead of completing the checkout process. For us to have the full picture of pricing and the PCB your ordering, please follow the steps in this guide here or here:

  1. Click "Secure Checkout": After adding your PCB to the cart
  2. Enter your shipping information and add a coupon code if you have one, then click "Submit Order", do not add any payment options
  3. Close that tab and open a new one to jlcpcb.com, then click "Order History" and take a screenshot. It should show all the details of your order.

Please take a screenshot of your unpaid order instead of a picture of your cart, and upload it as cart.png. This will allow us to spot any mistakes and give you ways to reduce the cost or customs fee. Congrats on making the PCB!

@eyestare
Copy link
Contributor Author

Thanks for the update! I just changed cart.png. Please let me know if anything else is needed! :)

@LimesKey
Copy link
Collaborator

I see you've chosen Standard Assembly, that assembly is very costly and we strongly recommend choosing Economic Assembly. If you run into issues, ask in the #onboard-help channel.

@eyestare
Copy link
Contributor Author

Just fixed! :)

@LimesKey
Copy link
Collaborator

Thanks for your cart adjustment. I see that your schematic.pdf is just a screenshot of your PCB, can you submit the actual electrical schematic on the Schematic tab of EasyEDA? Take a look at other submissions for an example of what it should look like.

@eyestare
Copy link
Contributor Author

Oops, thanks!

Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your improvements to the Hackercard Jam on your PCB but it's unlikely that the LEDs will light up since the power provided by NFC is so little. You could try 2 LEDs in series while removing the resistor, and/or adding more capacitors, that might work. I'd recommend asking in #electronics channel on Slack for suggestions!

@eyestare
Copy link
Contributor Author

Fixed, thanks for the note! :)

@LimesKey
Copy link
Collaborator

Have you asked people in the #electronics channel or #onboard-help channel confirming it would work? I think it would work but the LEDs would just be dim, sorry I can't be of more help. But if you're ok with it not 100% working I can give you the grant still.

@eyestare
Copy link
Contributor Author

I looked into it a bit online, and I'm fine with it. Thanks for all the help! :)

Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eyestare!

I've just sent you your grant for OnBoard. You should have received an invite in your email. There will be instructions on how to use your debit card attached should you need them. Please remember to upload your receipts when you make purchases.

Also, unfortunately, we're unable to offer support with reimbursements for customs fees, including reimbursements using leftover grant funds. Please keep this in mind before you make any purchases. More info in the OnBoard community shipping doc.

I'm looking forward to seeing your PCB be manufactured! Send pictures in the #electronics channel on Slack once you get it! Please don't hesitate to reach out if you have any questions!

@LimesKey LimesKey merged commit baaa886 into hackclub:main Aug 16, 2024
3 checks passed
24c02 pushed a commit that referenced this pull request Oct 8, 2024
* Create README.md

* Add files via upload

* Rename Gerber_NFC-Hacker-Card_PCB_NFC-Hacker-Card_2024-08-06.zip to gerber.zip

* Rename PCB_PCB_NFC-Hacker-Card_2024-08-06.pdf to schematic.pdf

* Rename Screenshot 2024-08-06 133414.png to cart.png

* Update and rename PCB_PCB_NFC-Hacker-Card_2024-08-06.json to pcb.json

* Update and rename SCH_NFC-Hacker-Card_2024-08-06.json to schematic.json

* Add files via upload

* Update README.md

* Delete projects/ankitas-nfc-card/cart.png

* Add files via upload

* Delete projects/ankitas-nfc-card/cart.png

* Add files via upload

* Update README.md

* Update README.md

* Delete projects/ankitas-nfc-card/cart.png

* Add files via upload

* Delete projects/ankitas-nfc-card/schematic.pdf

* Add files via upload

* Delete projects/ankitas-nfc-card/cart.png

* Delete projects/ankitas-nfc-card/gerber.zip

* Delete projects/ankitas-nfc-card/schematic.pdf

* Delete projects/ankitas-nfc-card/src/schematic.json

* Delete projects/ankitas-nfc-card/src/pcb.json

* Add files via upload

* Add files via upload

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submission New Boards!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants