Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LED heart #991

Merged
merged 40 commits into from
Sep 6, 2024
Merged

LED heart #991

merged 40 commits into from
Sep 6, 2024

Conversation

aGuyWhoHasGithub
Copy link
Contributor

Submission Checklist:

  • [ X ] I am a current high school, middle school, or home schooled student.

  • [ X ] I have joined the #electronics channel on Slack

  • [ X ] I made this board from scratch, even if I followed a tutorial

  • [ X ] I have followed the directions in README.md

    • [ X ] Created a folder under onboard/projects
    • [ X ] Filled out TEMPLATE.md as README.md inside your project folder
    • [ X ] Uploaded gerber.zip and schematic.pdf inside your project folder
    • [ X ] Created a folder called src and uploaded design files
    • [ X ] Uploaded screenshot of PCB order called cart.png with all costs included
    • [ X ] I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • [ X ] If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)

  • (Optional) This project is from a tutorial1.

  • (Optional) This project is for OnBoard Live2.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩

  2. OnBoard Live is a special version of OnBoard where you can earn more money for designing advanced boards. Check out the #onboard-live channel on our Slack! ↩

@github-actions github-actions bot added the Submission New Boards! label Aug 15, 2024
@prophetorpheus
Copy link
Collaborator

prophetorpheus commented Aug 15, 2024 •
edited
Loading

Hi, I'm Orpheus Leap! Here to help you review your PR.

projects/Heart with leds:

Required files
✅ README.md A description of your project
✅ cart.png cart.png
projects/Heart with leds/gerber files/archivos gerber.zip:

Happy OnBoarding!
This bot is a simpler helper for common submission types. If there's an error with this, please point it out and someone from the OnBoard team will look at it manually.

@blazecoding2009 blazecoding2009 self-assigned this Aug 16, 2024
@blazecoding2009
Copy link
Collaborator

Hey @aGuyWhoHasGithub

Thanks for submitting your PCB pull request for OnBoard! However, it looks like you took a picture of the cart ordering process instead of completing the checkout process. For us to have the full picture of pricing and the PCB your ordering, please follow the steps in this guide here or here:

Click "Secure Checkout": After adding your PCB to the cart
Enter your shipping information and add a coupon code if you have one, then click "Submit Order", do not add any payment options
Close that tab and open a new one to jlcpcb.com, then click "Order History" and take a screenshot. It should show all the details of your order.
Please take a screenshot of your unpaid order instead of a picture of your cart, and upload it as cart.png. This will allow us to spot any mistakes and give you ways to reduce the cost or customs fee. Congrats on making the PCB!

@aGuyWhoHasGithub
Copy link
Contributor Author

aGuyWhoHasGithub commented Aug 17, 2024 via email

@blazecoding2009
Copy link
Collaborator

@aGuyWhoHasGithub

That is still not the right image, also please fix the file names.

@blazecoding2009
Copy link
Collaborator

Goodnight, its ok for the delay, ty very much. Btw i already uploaded the schematic file, i recognize that my repo may be a little untidy but you can find it really easy, there are 2 schematic files(i don't remember why but both are the same), one in the src folder and the other one in the main folder of my project.
…
On Sun, Aug 25, 2024, 20:34 blaze @.> wrote: @.* requested changes on this pull request. Could you upload the schematic to this? Sorry about the delay — Reply to this email directly, view it on GitHub <#991 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKC4FKV2LTNYJYDZMSDDAV3ZTJSWXAVCNFSM6AAAAABMSUG5LKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJZGQYDANRRGM . You are receiving this because you were mentioned.Message ID: @.***>

Hey, we need the schematic.pdf, not the kicad version

@aGuyWhoHasGithub
Copy link
Contributor Author

aGuyWhoHasGithub commented Aug 26, 2024 via email

@blazecoding2009
Copy link
Collaborator

Oh sorry, but how can i be able to export the schematic as a pdf file using kicad? Because kicad doesnt have that feature and I even though that uploading the schematic, pcb and .kicad_pro files was an alternative in case ppl used kicad as their pcb design software, or at least that's what the onboard repo says if I remember well....
…
On Mon, Aug 26, 2024, 09:36 blaze @.> wrote: Goodnight, its ok for the delay, ty very much. Btw i already uploaded the schematic file, i recognize that my repo may be a little untidy but you can find it really easy, there are 2 schematic files(i don't remember why but both are the same), one in the src folder and the other one in the main folder of my project. … <#m_8789885721371076763_> On Sun, Aug 25, 2024, 20:34 blaze @.> wrote: @. requested changes on this pull request. Could you upload the schematic to this? Sorry about the delay — Reply to this email directly, view it on GitHub <#991 (review) <#991 (review)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKC4FKV2LTNYJYDZMSDDAV3ZTJSWXAVCNFSM6AAAAABMSUG5LKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJZGQYDANRRGM . You are receiving this because you were mentioned.Message ID: @.> Hey, we need the schematic.pdf, not the kicad version — Reply to this email directly, view it on GitHub <#991 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKC4FKSHBTLSQPUJ7DUGTJ3ZTMONFAVCNFSM6AAAAABMSUG5LKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGEYDQOBQGE . You are receiving this because you were mentioned.Message ID: @.>

@LimesKey would you mind telling them how to export their schematic as a PDF from kicad?

@LimesKey
Copy link
Collaborator

Go to the KiCad Schematic editor, then File > Plot, and press Plot Current Page with the correct output directory. See here for more instructions.

@aGuyWhoHasGithub
Copy link
Contributor Author

aGuyWhoHasGithub commented Aug 29, 2024 via email

@blazecoding2009
Copy link
Collaborator

Here it is, i apologize for the delay El lun, 26 ago 2024 a la(s) 12:21 p.m., LimesKey @.) escribió:
…
Go to the KiCad Schematic editor, then File > Plot, and press Plot Current Page with the correct output directory. See here https://github.com/LimesKey/OnBoard/blob/main/docs/KiCad_Beginner_Guide.md for more instructions. — Reply to this email directly, view it on GitHub <#991 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKC4FKRM5QLRGUYI52AV4CLZTNBWJAVCNFSM6AAAAABMSUG5LKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGQ3TEMZWHA . You are receiving this because you were mentioned.Message ID: @.>

I can't seem to find it

@aGuyWhoHasGithub
Copy link
Contributor Author

aGuyWhoHasGithub commented Aug 29, 2024 via email

@blazecoding2009
Copy link
Collaborator

Sorry but to find what?
…
On Wed, Aug 28, 2024, 23:51 blaze @.> wrote: Here it is, i apologize for the delay El lun, 26 ago 2024 a la(s) 12:21 p.m., LimesKey @. ) escribió: … <#m_4220700020355052484_> Go to the KiCad Schematic editor, then File > Plot, and press Plot Current Page with the correct output directory. See here https://github.com/LimesKey/OnBoard/blob/main/docs/KiCad_Beginner_Guide.md https://github.com/LimesKey/OnBoard/blob/main/docs/KiCad_Beginner_Guide.md for more instructions. — Reply to this email directly, view it on GitHub <#991 (comment) <#991 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKC4FKRM5QLRGUYI52AV4CLZTNBWJAVCNFSM6AAAAABMSUG5LKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGQ3TEMZWHA https://github.com/notifications/unsubscribe-auth/BKC4FKRM5QLRGUYI52AV4CLZTNBWJAVCNFSM6AAAAABMSUG5LKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGQ3TEMZWHA . You are receiving this because you were mentioned.Message ID: @.> I can't seem to find it — Reply to this email directly, view it on GitHub <#991 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKC4FKRBOM4NVHF4PTTTRTLZT2EEZAVCNFSM6AAAAABMSUG5LKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJWGYYTIMZWGM . You are receiving this because you were mentioned.Message ID: @.>

I can't find the schematic

@aGuyWhoHasGithub
Copy link
Contributor Author

aGuyWhoHasGithub commented Aug 29, 2024 via email

@blazecoding2009
Copy link
Collaborator

Please UPLOAD the pdf to your project folder

@aGuyWhoHasGithub
Copy link
Contributor Author

aGuyWhoHasGithub commented Aug 29, 2024 via email

@aGuyWhoHasGithub
Copy link
Contributor Author

aGuyWhoHasGithub commented Aug 29, 2024 via email

blazecoding2009
blazecoding2009 requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@blazecoding2009 blazecoding2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move it outside the src folder and remove the kicad files which are not inside the src folder

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Hi, if you need any assistance, please don't hesitate to ask here or in #electronics on Slack. This pull request is being marked as 'Stalled' for now and will be closed in 3 days if there is no activity.

@github-actions github-actions bot added the Stalled In progress, waiting for update from user or reviewer label Sep 5, 2024
@github-actions github-actions bot removed the Stalled In progress, waiting for update from user or reviewer label Sep 6, 2024
@aGuyWhoHasGithub
Copy link
Contributor Author

aGuyWhoHasGithub commented Sep 6, 2024 via email

blazecoding2009
blazecoding2009 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@blazecoding2009 blazecoding2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Have fun with your grant!

@blazecoding2009 blazecoding2009 merged commit 7f3d3c0 into hackclub:main Sep 6, 2024
3 checks passed
@aGuyWhoHasGithub
Copy link
Contributor Author

aGuyWhoHasGithub commented Sep 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blazecoding2009 blazecoding2009 blazecoding2009 approved these changes

Assignees

@blazecoding2009 blazecoding2009

Labels
Submission New Boards!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aGuyWhoHasGithub @prophetorpheus @blazecoding2009 @LimesKey