Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing tests #1249 #1466

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

routing tests #1249 #1466

wants to merge 4 commits into from

Conversation

whitneywind
Copy link
Member

For issue #1249

  • These tests check that the routing works correctly as a user navigates through both the pre-form and form pages.
  • The tests fill manually navigate from page to page checking that the url and the next page's contents are correct

@whitneywind whitneywind added the ready for dev lead task ready for dev lead to evaluate label Jun 26, 2024
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @whitneywind! I sent you a message on slack, but I'm seeing a lot of warnings and errors when I run the tests.

@sydneywalcoff sydneywalcoff removed the ready for dev lead task ready for dev lead to evaluate label Jul 6, 2024
@sydneywalcoff sydneywalcoff self-requested a review July 8, 2024 21:06
@sydneywalcoff sydneywalcoff added ready for dev lead task ready for dev lead to evaluate and removed ready for dev lead task ready for dev lead to evaluate labels Jul 8, 2024
@whitneywind
Copy link
Member Author

I fixed the errors that were occurring with the tests and hid the warnings that had to do with linking the MUI styles!

@whitneywind whitneywind added the ready for dev lead task ready for dev lead to evaluate label Jul 15, 2024
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @whitneywind ! The error from before is gone and all the warnings are hidden! Great job on that!

I'm getting a new error however. I'm attaching a screenshot (of most of the error) below.
Screenshot 2024-07-15 at 7 30 09 PM

I ran an npm i and checked the package.json and didn't see the 'canvas' dependency it's looking for.

@whitneywind
Copy link
Member Author

@sydneywalcoff I removed a setup file that mentioned canvas and the tests are working without any errors on my end! Please let me know if you're still getting that error

Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitneywind I'm still getting that same error :( I'll message you on slack

@sydneywalcoff sydneywalcoff removed the ready for dev lead task ready for dev lead to evaluate label Jul 26, 2024
@whitneywind
Copy link
Member Author

@sydneywalcoff It's working for me without errors with node versions 16 and 18. I did have to reinstall the packages for the version 16 when I tested it with that. Is it working for you? And is there a specific node version that it should be used with?

@whitneywind whitneywind added the ready for dev lead task ready for dev lead to evaluate label Aug 6, 2024
@sydneywalcoff
Copy link
Member

hey @whitneywind,

Can you create a new branch off of dev and copy over your changes? It'll be the easiest way to resolve the merge conflict.
You'll need to open a new PR when you do.

@sydneywalcoff sydneywalcoff removed the ready for dev lead task ready for dev lead to evaluate label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants