-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routing tests #1249 #1466
base: dev
Are you sure you want to change the base?
routing tests #1249 #1466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @whitneywind! I sent you a message on slack, but I'm seeing a lot of warnings and errors when I run the tests.
I fixed the errors that were occurring with the tests and hid the warnings that had to do with linking the MUI styles! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @whitneywind ! The error from before is gone and all the warnings are hidden! Great job on that!
I'm getting a new error however. I'm attaching a screenshot (of most of the error) below.
I ran an npm i
and checked the package.json and didn't see the 'canvas' dependency it's looking for.
@sydneywalcoff I removed a setup file that mentioned canvas and the tests are working without any errors on my end! Please let me know if you're still getting that error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whitneywind I'm still getting that same error :( I'll message you on slack
@sydneywalcoff It's working for me without errors with node versions 16 and 18. I did have to reinstall the packages for the version 16 when I tested it with that. Is it working for you? And is there a specific node version that it should be used with? |
hey @whitneywind, Can you create a new branch off of dev and copy over your changes? It'll be the easiest way to resolve the merge conflict. |
For issue #1249