1247 Textarea testing #1490
Open
1247 Textarea testing #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydneywalcoff
requested changes
Aug 11, 2024
There was a problem hiding this comment.
@eburdekin Hey Eileen!
These look great I had one small suggestion below!
Comment on lines
107
to
109
| const input = getByPlaceholderText('Type here'); | ||
| userEvent.click(input); | ||
| expect(input).toHaveFocus(); |
There was a problem hiding this comment.
There are other ways to focus on a text area, like tabbing from the a different element. Our tests should cover that as well.
|
Thanks @sydneywalcoff ! Added tests to account for tabbing onto the elements. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1247
Changes made:
Added tests for the following:
Reason for changes:
We want to retroactively implement testing to better protect our codebase