Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Attribution Banner to Map with Contribution Link #17

Merged

Conversation

ThorntonMatthewD
Copy link
Collaborator

@ThorntonMatthewD ThorntonMatthewD commented Oct 8, 2023

Summary

Adds an attribution control element to the bottom-right corner of the map. It lets anyone who navigates to the homepage know who is behind the project and where they can go to get involved.

I've also added in attribution to OpenStreetMap for the base layer.

Screenshots

Desktop

Screenshot_2023-10-07_23-47-58

Mobile

Screenshot_2023-10-07_23-45-21

Testing Plan

  1. The attribution control bar will be visible in the bottom-right corner of the map whenever the main page is loaded.
  2. Ensure that the three hyperlinks contained within all are oeprational and take you to the expected pages.

@ThorntonMatthewD
Copy link
Collaborator Author

I think I'd like to explore other options for addressing #11 to prevent things from getting too cramped, but I thought this was a positive change on its own.

@ThorntonMatthewD ThorntonMatthewD marked this pull request as ready for review October 8, 2023 03:54
Copy link
Member

@oliviasculley oliviasculley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oliviasculley oliviasculley merged commit 6eaad7c into hackgvl:develop Oct 8, 2023
1 check passed
@oliviasculley
Copy link
Member

@all-contributors add @ThorntonMatthewD as a contributor for code, test

@allcontributors
Copy link

@oliviasculley

I've put up a pull request to add @ThorntonMatthewD! 🎉

@ThorntonMatthewD ThorntonMatthewD deleted the add-maintainer-banner branch October 8, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants