Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contribution Control to Map #23

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

ThorntonMatthewD
Copy link
Collaborator

@ThorntonMatthewD ThorntonMatthewD commented Oct 12, 2023

Fixes #11 and touches on #10.

Summary

Whenever at least one map layer is active a new icon will appear in the top-right corner of the map. Whenever it is hovered over (or tapped on mobile) a pop-up will appear showing the following:

  • Each active map layer's name
  • The contribution link for each layer (if one is available - it is omitted if absent)
  • Each maintainer's name, which is a clickable link if they've provided a web address to be associated with their contributions.

Screenshots & Video

(Sorry - I tried putting them side-by-side in a couple of tables, but I could embed videos in there)

Desktop

Screenshot_2023-10-11_23-37-42

desktop-contributor-popup.mp4

Mobile

Screenshot_2023-10-13_17-03-03

mobile-contributor-popup.mp4

Testing Plan

This one is a bit more open-ended.

  • Ensure that whenever there are no feature sets enabled that the maintainers icon/control is not visible.
  • Whenever a layer(s) is enabled, ensure it is visible. Every layer you enable should be represented in the pop-up.
  • Whenever a layer is enabled, and then disabled, it should be removed from the pop-up.
  • Contribution and maintainer links should all open up new tabs whenever clicked.
  • I'd encourage you to try to enable a ton of layers and make sure the scrolling/overflow aspect works. It's admittedly a bit wonky since if you use the scroll wheel on your mouse leaflet kind of hijacks that for zooming the map. For now you'll need to click-and-drag the scroll bar. 😞
  • Please make sure that the new elements look good at a variety of screen sizes.
  • Use Lighthouse, Firefox's Accessibility Inspector, and/or whatever other accessibility testing tools (if you use something else, please let me know! I'd love to hear what you use) to make sure that this functionality can be enjoyed by as many users as possible.

@ThorntonMatthewD ThorntonMatthewD self-assigned this Oct 12, 2023
@ThorntonMatthewD ThorntonMatthewD marked this pull request as ready for review October 12, 2023 03:55
Copy link
Member

@oliviasculley oliviasculley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution, this looks fantastic!

@oliviasculley oliviasculley merged commit 659419c into hackgvl:develop Oct 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display map layer contributors
2 participants