Don't sign git tags #283
Merged
Don't sign git tags #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: when the git config setting `tag.gpgSign=true` is used, this implies the `-s` option to `git tag`. This means that git needs a message for the tag. Because no message is given, git invokes an editor, which doesn't work when running non-interactively. We don't need signed tags in a git repo created by HaikuPorter, so the easiest solution is to pass `--no-sign` to `git tag` calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: when the git config setting
tag.gpgSign=trueis used, this implies the-soption togit tag. This means that git needs a message for the tag. Because no message is given, git invokes an editor, which doesn't work when running non-interactively.We don't need signed tags in a git repo created by HaikuPorter, so the easiest solution is to pass
--no-signtogit tagcalls.