Develop (0.1.0) #94
Merged
Develop (0.1.0) #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cql Session Connection Pool Test
akageun
commented
Jul 30, 2024
| api("com.datastax.oss:java-driver-core:${datastaxJavaDriverVersion}") | ||
| api("com.datastax.oss:java-driver-query-builder:${datastaxJavaDriverVersion}") | ||
| api("com.datastax.oss:java-driver-mapper-runtime:${datastaxJavaDriverVersion}") | ||
| implementation("com.datastax.oss:java-driver-core:${datastaxJavaDriverVersion}") |
There was a problem hiding this comment.
Core 영역에서만 driver 관련 로직 작성하도록 설정 변경했습니다.
| @@ -59,30 +45,14 @@ public CqlSession makeSession(ClusterConnection clusterConnection, String keyspa | |||
|
|
|||
| builder.withConfigLoader( | |||
| DriverConfigLoader.programmaticBuilder() | |||
| // .withDuration(DefaultDriverOption.HEARTBEAT_INTERVAL, Duration.ofSeconds(30)) | |||
There was a problem hiding this comment.
HEARTBEAT 설정에 대해서 확인하고 추후 System Config 로 설정할 수 있게 할 예정 입니다.
|
|
||
| return Version.parse(row.getString("release_version")); | ||
| return node.getCassandraVersion(); |
There was a problem hiding this comment.
논의할 것처럼 Driver 에서 제공해주는 버전처리로 일원화 했습니다.
| @@ -27,4 +29,11 @@ protected CqlSession makeSession() { | |||
| .withLocalDatacenter("dc1") | |||
| .build(); | |||
| } | |||
| protected CqlSession makeSession(String keyspaceName) { | |||
There was a problem hiding this comment.
test 용 컨피그 생성한 다음 해당 설정을 cluster 로직 태워서 생성할 수 있도록 변경할 예정 입니다.
seungh0
approved these changes
Jul 31, 2024
seungh0
reviewed
Jul 31, 2024
Comment on lines
8
to
10
| // implementation("com.datastax.oss:java-driver-core:${datastaxJavaDriverVersion}") | ||
| // implementation("com.datastax.oss:java-driver-query-builder:${datastaxJavaDriverVersion}") | ||
| // implementation("com.datastax.oss:java-driver-mapper-runtime:${datastaxJavaDriverVersion}") |
* Update README (License) * Auto Assign Code Reviewers
|
전에 의논했던거랑 반대로, 이런 형태의 플젝의 경우 main, develop 두 개 분리해서 이점이 크게 없는거 같네요. |
seungh0
reviewed
Jul 31, 2024
| return CqlSession.builder() | ||
| .addContactPoint(new InetSocketAddress("127.0.0.1", 29042)) | ||
| .withLocalDatacenter("dc1") | ||
| .withKeyspace(keyspaceName) |
There was a problem hiding this comment.
.withKeyspace Cassandra 4.x 미만에서 호환 안되었던걸로 기억해요
|
네. 저도 이거에 대해서 논의하고 싶었습니다. develop 으로 가는거 말고...
2번의 경우 오버스팩인거 같아서 1번으로 가는게 좋아보이긴 합니다. 이번꺼까지만 하고, 다음 릴리즈부터는 1번으로 갑시다! |
|
저도 1번이 좋은거 같습니다. |
* Refactoring Code Smell * ClusterManager CLUSTER public -> private
* Cluster Version Evaluator * Prevent registration of unsupported Cassandra versions in the cluster
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) to 4.1.4 and updates ancestor dependency [node-sass](https://github.com/sass/node-sass). These dependencies need to be updated together. Updates `tough-cookie` from 2.5.0 to 4.1.4 - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v2.5.0...v4.1.4) Updates `node-sass` from 7.0.3 to 9.0.0 - [Release notes](https://github.com/sass/node-sass/releases) - [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md) - [Commits](sass/node-sass@v7.0.3...v9.0.0) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect - dependency-name: node-sass dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Refactor Code Smell * Refactor Code Smell
* Build Tool Npm to Yarn * Build Tool Npm to Yarn * Build Tool Npm to Yarn
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.