Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jdk17): use java.specification.version for web3ClientVersion #35

Open
wants to merge 1 commit into
base: arch/arm64
Choose a base branch
from

Conversation

halibobo1205
Copy link
Owner

@halibobo1205 halibobo1205 commented Oct 21, 2024

What does this PR do?

  • use java.specification.version instead of parsing java.version

Refs: JEP 322, JDK-8192828

Why are these changes required?

  • ensure consistent version reporting across different Java releases(jdk10+)

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

…jdk version retrieval

  - use `java.specification.version` instead of parsing `java.version`
  - ensure consistent version reporting across different Java releases(jdk10+)
@halibobo1205 halibobo1205 changed the title feat(json-rpc/web3ClientVersion): use java.specification.version for jdk version retrieval feat(jdk17): use java.specification.version for web3ClientVersion Oct 23, 2024
@halibobo1205 halibobo1205 changed the base branch from develop to arch/arm64 October 31, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant