Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install capybara #21

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Install capybara #21

merged 3 commits into from
Nov 6, 2023

Conversation

timriley
Copy link
Member

@timriley timriley commented Nov 4, 2023

This helps make feature specs usable right from the very beginning, and will allow us to remove a bunch of manual setup instructions from our getting started guide for 2.1.

@timriley
Install capybara
03d8af2 
This helps make feature specs usable right from the very beginning, and will allow us to remove a bunch of manual setup instructions from our getting started guide for 2.1.
@timriley timriley requested a review from jodosha November 4, 2023 10:34
@timriley timriley self-assigned this Nov 4, 2023
@timriley timriley added this to the v2.1.0 milestone Nov 4, 2023
jodosha
jodosha approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@jodosha jodosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timriley Good one. Do we need to introduce a tag for feature tests?

@timriley
Copy link
Member Author

timriley commented Nov 6, 2023 •
edited
Loading

@jodosha By tag, do you mean RSpec metadata? If so, using RSpec.feature will give the tests type: :feature metadata automatically, and therefore the tests will have access to all the Capybara features.

If you don't mean RSpec metadata, would you mind explaining what you mean? 😄

@timriley timriley merged commit 35af40a into main Nov 6, 2023
6 checks passed
@timriley timriley deleted the install-capybara branch November 6, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodosha jodosha jodosha approved these changes

Assignees

@timriley timriley

Labels
None yet
Projects
Hanami 2.1
Status: Done
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timriley @jodosha