Fix icon flicker #157
Merged
Fix icon flicker #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Sep 27, 2024
source/extension.svelte
Outdated
| // Get a large icon closest to the desired size | ||
| for (const icon of icons.reverse()) { | ||
| for (const icon of sortedIcons) { |
There was a problem hiding this comment.
Good catch! We can actually use .toSorted() now
fregante
requested changes
Sep 27, 2024
fregante
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #146
The reason that some icon change while toggling the state of other extensions is the use of
reverseon icon list.To fix it, use a simple sort function to make sure the order does not change.