Feature: Powder Chest Timer #2204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jani270
reviewed
Sep 21, 2024
src/main/java/at/hannibal2/skyhanni/config/features/mining/PowderTrackerConfig.java
Outdated
Show resolved
Hide resolved
…owder-chest-timer
…owder-chest-timer
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
jani270
added
the
Soon
CalMWolfs
requested changes
Oct 10, 2024
src/main/java/at/hannibal2/skyhanni/config/features/mining/PowderChestTimerConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/mining/PowderChestTimerConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/mining/PowderChestTimerConfig.java
Outdated
Show resolved
Hide resolved
hannibal002
added
Soon
…derChestTimerConfig.java Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
…derChestTimerConfig.java Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
…derChestTimerConfig.java Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
CalMWolfs
requested changes
Oct 14, 2024
ItsEmpa
suggested changes
Oct 16, 2024
src/main/java/at/hannibal2/skyhanni/config/features/mining/PowderChestTimerConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/mining/PowderChestTimerConfig.java
Outdated
Show resolved
Hide resolved
|
|
||
| @SubscribeEvent | ||
| fun onWorldChange(event: LorenzWorldChangeEvent) { | ||
| if (!isEnabled()) return |
There was a problem hiding this comment.
dont add a config check inside the world change event
| else -> continue | ||
| } | ||
|
|
||
| if (sorted.isNotEmpty()) { |
There was a problem hiding this comment.
make this be an early return with if (sorted.isEmpty()) continue
| if (sorted.isNotEmpty()) { | ||
| val chestToConnect = sorted.take(config.drawLineToChestAmount) | ||
| if (chestToConnect.isNotEmpty()) { | ||
| val (firstPos, firstTime) = chestToConnect.first() |
There was a problem hiding this comment.
instead of checking isNotEmpty and then doing .first(), you can just do .firstOrNull() ?: continue
…derChestTimerConfig.java Co-authored-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
…derChestTimerConfig.java Co-authored-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
CalMWolfs
approved these changes
Oct 22, 2024
hannibal002
removed
the
Soon
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a timer in the style of the Barn Fishing timer that show you when the first chest you uncovered is gonna despawn.
Images
Changelog New Features