Feature: Mute High Heat sound in the Magma Fields #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thunderblade73
suggested changes
Sep 22, 2024
hannibal002
requested changes
Sep 23, 2024
src/main/java/at/hannibal2/skyhanni/features/mining/crystalhollows/HighHeatSound.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/crystalhollows/HighHeatSound.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/crystalhollows/HighHeatSound.kt
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
…ting # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/ScoreboardElements.kt # src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/UnknownLinesHandler.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
…ting # Conflicts: # src/main/java/at/hannibal2/skyhanni/config/features/mining/MiningConfig.java # src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/CustomScoreboardUtils.kt # src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/ScoreboardElements.kt # src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/UnknownLinesHandler.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
ItsEmpa
suggested changes
Oct 16, 2024
CalMWolfs
added
the
Soon
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
ItsEmpa
suggested changes
Oct 26, 2024
| @SubscribeEvent | ||
| fun onSound(event: PlaySoundEvent) { | ||
| if (!isEnabled()) return | ||
| if (!(LocationUtils.playerLocation().y <= 65.0 && MiningAPI.heat >= 90)) return |
There was a problem hiding this comment.
Suggested change
| if (!(LocationUtils.playerLocation().y <= 65.0 && MiningAPI.heat >= 90)) return | |
| if (LocationUtils.playerLocation().y > 65.0 || MiningAPI.heat < 90) return |
hannibal002
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
adds a toggle to mute the high heat sound in the magma fields when at or above 90 heat
suggestion
Changelog New Features