-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Command Register Event #2642
Backend: Command Register Event #2642
Conversation
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
…into backend/command-register-event
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked for me and looks exciting
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
Conflicts have been resolved! 🎉 |
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
…ister-event # Conflicts: # src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
Conflicts have been resolved! 🎉 |
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
TODO @ hani
spin the order of commands around and change the names and categories
also improve the "changelog improvements"
What
This Pull Request is another step toward modern version support where creating commands is even based, instead of the the 1.8 way.
It reduces clutter by cleaning up Commands.kt and moving most commands in their own class where they are supposed to be (todo in a later pr?).
It also reduces the amount of merge conflicts in the main commands file (not a lot though)
Replaces #2421
Commands that got changed:
Changelog Improvements
Changelog Technical Details