Backend: Better formatting settings #3104
Merged
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Backend
One or more Detekt Failures were detected:
|
CalMWolfs
requested changes
Dec 21, 2024
There was a problem hiding this comment.
We have a custom rule for annotation spacing in detekt so that it works with preprocessed comments. Add whatever you are trying to do into that custom rule instead.
Unfortunately there is no way to have preprocessing comments while also having it follow typical kotlin formatting standards unless we want to duplicate lines
… when the mining event display is disabled.
CalMWolfs
approved these changes
Dec 22, 2024
github-actions
bot
removed
the
Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Apparently, they are better now. I'd like to have feedback from others that actually know what they are doing.
This no longer breaks my auto-formatting (makes it so that IntelliJ formatting doesn't break detekt rules)
Changelog Technical Details