Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: shwords causing blank messages in chat #3110

Merged
merged 4 commits into from
Dec 25, 2024

Conversation

NopoTheGamer
Copy link
Contributor

@NopoTheGamer NopoTheGamer commented Dec 24, 2024

What

Fixes chat messages becoming blank if they are too long after being effected by /shwords.
This has a small downside:
Messages sent before turning on the shwords will look like this:
image
Messages sent while shwords is on look normal: (However they stay like this even after turning off the rule)
image

This does not effect the messages text anywhere else as far as I could tell.
The Minecraft log, /shchathistory and chat events all have the correct text

Images

unlucky they arent in the dropdown

Changelog Fixes

  • Fixed shwords causing blank messages in chat. - nopo

@github-actions github-actions bot added the Bug Fix Bug fixes label Dec 24, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Extra info is not filled out in text: * Extra info.

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added Wrong Title/Changelog There is an error in the title or changelog and removed Wrong Title/Changelog There is an error in the title or changelog labels Dec 24, 2024
@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Dec 24, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 25, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 25, 2024
@hannibal002 hannibal002 merged commit 52c078a into hannibal002:beta Dec 25, 2024
6 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants