-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Base Stats #3197
Merged
Merged
Backend: Base Stats #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannibal002
added
Soon
This Pull Request will be merged within the next couple of betas
Backend
A backend pull request that will be merged soon
labels
Jan 10, 2025
One or more Detekt Failures were detected:
|
One or more Detekt Failures were detected:
|
CalMWolfs
requested changes
Jan 10, 2025
src/main/java/at/hannibal2/skyhanni/data/jsonobjects/other/SkyblockItemsDataJson.kt
Show resolved
Hide resolved
oh boy
|
Ive fixed all cases. |
CalMWolfs
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked for me.
but unfortunately this isnt a method that provides 100% of data as hypixel doesnt have the data of some items in the api such as PUMPKIN_DICER
github-actions
bot
removed
Soon
This Pull Request will be merged within the next couple of betas
Backend
A backend pull request that will be merged soon
labels
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Read item base stats from hypixel api and provice utils functions to work with it, and show those stats in item lore via a debug toggle.
Changelog Technical Details