Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Base Stats #3197

Merged
merged 12 commits into from
Jan 11, 2025
Merged

Backend: Base Stats #3197

merged 12 commits into from
Jan 11, 2025

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Jan 10, 2025

What

Read item base stats from hypixel api and provice utils functions to work with it, and show those stats in item lore via a debug toggle.

Changelog Technical Details

  • Added Item Base Stats support. - hannibal2
    • Read item base stats from Hypixel Item API, provide utility functions, and display stats in item lore via debug toggle.

@hannibal002 hannibal002 added Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Jan 10, 2025
@hannibal002 hannibal002 added this to the Version 2.0.0 milestone Jan 10, 2025
@github-actions github-actions bot added the Detekt Has detekt problem label Jan 10, 2025
Copy link

One or more Detekt Failures were detected:

Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 10, 2025
@hannibal002
Copy link
Owner Author

hannibal002 commented Jan 11, 2025

oh boy

SkyHanni 1.3.0: Found unknown skyblock stats on items, please report this in disocrd
 
Caused by java.lang.IllegalStateException: found 14 stats via Hypixel Item API that are not in enum SkyblockStat
	at SH.utils.ItemUtils.verifyStats(ItemUtils.kt:77)
	at SH.utils.ItemUtils.updateBaseStats(ItemUtils.kt:56)
	at SH.features.inventory.bazaar.HypixelItemAPI.loadNpcPrices(HypixelItemAPI.kt:38)
	at SH.features.inventory.bazaar.HypixelItemAPI.access$loadNpcPrices(HypixelItemAPI.kt:15)
	at SH.features.inventory.bazaar.HypixelItemAPI$start$1.invokeSuspend(HypixelItemAPI.kt:51)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)

Extra data:
TROPHY_FISH_CHANCE: 'on ODGERS_SILVER_TOOTH'
WALK_SPEED: 'on FIERY_HOLLOW_BOOTS'
WEAPON_ABILITY_DAMAGE: 'on HOLLOW_WAND'
ABILITY_DAMAGE_PERCENT: 'on FIERY_AURORA_HELMET'
CRITICAL_DAMAGE: 'on FIERY_CRIMSON_CHESTPLATE'
RIFT_TIME: 'on VAMPIRE_DENTIST_RELIC'
CRITICAL_CHANCE: 'on BONE_NECKLACE'
ATTACK_SPEED: 'on TERMINATOR'
RIFT_DAMAGE: 'on TACTICIAN_MURDER_WEAPON'
RIFT_WALK_SPEED: 'on SILVER_LACED_KARAMBIT'
RIFT_INTELLIGENCE: 'on TEST_VAMPIRE_CHESTPLATE'
RIFT_MANA_REGEN: 'on TEST_VAMPIRE_CHESTPLATE'
RIFT_HEALTH: 'on TEST_VAMPIRE_CHESTPLATE'
HEALTH_REGENERATION: 'on GILLSPLASH_BELT'

@hannibal002
Copy link
Owner Author

Ive fixed all cases.

@hannibal002 hannibal002 requested a review from CalMWolfs January 11, 2025 01:11
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me.
but unfortunately this isnt a method that provides 100% of data as hypixel doesnt have the data of some items in the api such as PUMPKIN_DICER

@hannibal002 hannibal002 merged commit 7d4e044 into beta Jan 11, 2025
11 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants