Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeScript types #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix TypeScript types #393

wants to merge 1 commit into from

Commits on May 11, 2024

  1. Fix TypeScript types 

    Are the Types Wrong (https://arethetypeswrong.github.io/?p=%40hapi%2Fhoek%4011.0.4) was reporting the following errors:

* Used fallback condition - Import resolved to types through a conditional package.json export, but only after failing to resolve through an earlier condition. This behavior is a TypeScript bug. It may misrepresent the runtime behavior of this import and should not be relied upon.
* Masquerading as CJS - Import resolved to a CommonJS type declaration file, but an ESM JavaScript file.

This could result in TypeScript errors similar to the following, depending on the specific tsconfig.json options used:

> error TS7016: Could not find a declaration file for module '@hapi/hoek'. 'node_modules/@hapi/hoek/lib/index.mjs' implicitly has an 'any' type.
> There are types at 'node_modules/@hapi/hoek/lib/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@hapi/hoek' library may need to update its package.json or typings.
    @joshkel
    joshkel committed May 11, 2024
    Configuration menu
    Copy the full SHA
    e929191 View commit details
    Browse the repository at this point in the history