NOT A PR: Bug with Node 22 on all OSs #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unskip tests that were previously skipped and aren't failing. Fix JSON parse failure expectation given error message change after Node version 20.
damusix
commented
Jun 26, 2024
| @@ -467,10 +467,14 @@ | |||
| return Promise.reject(err); | |||
| } | |||
|
|
|||
| console.log('send...', encoded); | |||
| @@ -657,6 +661,8 @@ | |||
| return this.onError(new NesError(err, errorTypes.PROTOCOL)); | |||
| } | |||
|
|
|||
| console.log('update...', update); | |||
| @@ -49,6 +50,8 @@ exports = module.exports = internals.Listener = function (server, settings) { | |||
| return ws.close(); | |||
| } | |||
|
|
|||
| console.log('ws on connection....', req.headers); | |||
Headers are not being passed by websocket in node 22 only and causing cookie authentication to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue with Node 22 where cookies are not being sent by websockets. Console logging headers to trace what is being sent in all versions via pipeline, and isolation to only the test suite that is causing the issues.