Patch 1 #338
Closed
Patch 1 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To avoid potential compatibility issues, it is important to clearly specify the required dependency versions in your project documentation or user manuals. It is good practice to ensure flexibility and support for different configurations. This can be achieved by customizing your build or configuration scripts to be able to detect and act on the available version of libcurl as needed. |
|
The only thing I have fixed is the wrong name of the curl lib name from
libcurl-4.dll to libcurl-x64.dll. I don't understand your objection,
sorry. Can you clarify?
|
|
Hi Enrico,
libcurl-4.dll and libcurl.dll are valid names in previous curl versions.
Using only libcurl-x64.dll will inhibit the build of them.
Rafal is correctly suggesting to preserve backward compatibility in hbp
file for previous versions.
Best regards.
--
Maurizio
Il Ven 10 Nov 2023, 15:15 Enrico Maria Giordano ***@***.***>
ha scritto:
… The only thing I have fixed is the wrong name of the curl lib name from
libcurl-4.dll to libcurl-x64.dll. I don't understand your objection,
sorry. Can you clarify?
—
Reply to this email directly, view it on GitHub
<#338 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATLNKXXU22TTJNFSHFQH7TYDYZGVAVCNFSM6AAAAAA7GBRU3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVHAYTQNBSGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Ah, ok, I did not know. Done.
|
|
Anyway, please note that I had removed only libcurl-4.dll, not libcurl.dll. And I didn't find any curl package containing libcurl-4.dll. But you said that it exists so I trust you. |
|
Somebody could commit this change, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed libcurl 64-bit name