Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/hbsqlit3: Implemented SQLITE3_TRACE_V2(), SQLITE3_DB_FILENAME(), SQLITE3_EXPANDED_SQL() #343

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

tuffnatty
Copy link
Member

@tuffnatty tuffnatty commented Nov 15, 2023

SQLite 3.14.0 deprecates sqlite3_trace() and sqlite3_profile functions, so they may be unavailable in the linked library. This PR is to be applied after #342.

2023-11-16 18:12 UTC+0100 Phil Krylov (phil a t krylov.eu)

  • contrib/hbsqlit3/core.c
  • contrib/hbsqlit3/hbsqlit3.ch
  • contrib/hbsqlit3/hbsqlit3.hbx
    • Implemented SQLITE3_DB_FILENAME() on SQLite 3.7.10+.
    • Implemented SQLITE3_EXPANDED_SQL(), SQLITE3_TRACE_V2() on SQLite 3.14.0+.
      ; Thanks to Mindaugas Kavaliauskas for thorough reviewing!
  • contrib/hbsqlit3/tests/backup.prg
  • contrib/hbsqlit3/tests/demo.prg
    • Updated examples to use SQLITE3_TRACE_V2() on SQLite 3.14.0+.

@tuffnatty
Copy link
Member Author

@snaiperis I've updated the code, indeed the item had to be released, but it was not the only problem. Does it look good enough now?

@tuffnatty tuffnatty changed the title contrib/hbsqlit3: Implemented SQLITE3_TRACE_V2() contrib/hbsqlit3: Implemented SQLITE3_TRACE_V2(), SQLITE3_DB_FILENAME(), SQLITE3_EXPANDED_SQL() Nov 16, 2023
  * contrib/hbsqlit3/core.c
  * contrib/hbsqlit3/hbsqlit3.ch
  * contrib/hbsqlit3/hbsqlit3.hbx
    * Implemented SQLITE3_DB_FILENAME() on SQLite 3.7.10+.
    * Implemented SQLITE3_EXPANDED_SQL(), SQLITE3_TRACE_V2() on SQLite 3.14.0+.
    ; Thanks to Mindaugas Kavaliauskas for thorough reviewing!
  * contrib/hbsqlit3/tests/backup.prg
  * contrib/hbsqlit3/tests/demo.prg
    * Updated examples to use SQLITE3_TRACE_V2() on SQLite 3.14.0+.
@tuffnatty tuffnatty merged commit e8de2ab into harbour:master Nov 30, 2023
7 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant