🐛 Fix deleting objects from cloud storage

harehare · Oct 14, 2023 · 9db10f9 · 9db10f9
1 parent 07b2cba
commit 9db10f9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/backend/.air.toml b/backend/.air.toml
@@ -5,7 +5,7 @@ tmp_dir = "tmp"
 [build]
 args_bin = []
 bin = "./tmp/main"
-cmd = "go build -o ./tmp/main cmd/main.go"
+cmd = "go build -o ./tmp/main cmd/api-server/main.go"
 delay = 0
 exclude_dir = ["assets", "tmp", "vendor", "testdata"]
 exclude_file = []

diff --git a/backend/internal/infra/firebase/storage.go b/backend/internal/infra/firebase/storage.go
@@ -4,9 +4,11 @@ import (
 	"bytes"
 	"compress/gzip"
 	"context"
+	"errors"
 	"io"
 	"strings"
 
+	"cloud.google.com/go/storage"
 	firebaseStorage "firebase.google.com/go/v4/storage"
 	"github.com/samber/mo"
 )
@@ -102,6 +104,10 @@ func (s *CloudStorage) Delete(ctx context.Context, prefix, uid, itemID string) m
 	}
 
 	if err = bucket.Object(getObjectName(prefix, uid, itemID)).Delete(ctx); err != nil {
+		if ok := errors.Is(err, storage.ErrObjectNotExist); ok {
+			return mo.Ok(true)
+		}
+
 		return mo.Err[bool](err)
 	}