_sendRequest method also uses requestParams

+ added semicolon for consistency sake
harrisiirak · Aug 28, 2015 · d7ab9af · d7ab9af
1 parent af8ada6
commit d7ab9af
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/lib/webhdfs.js b/lib/webhdfs.js
@@ -164,7 +164,7 @@ WebHDFS.prototype._sendRequest = function _sendRequest (method, url, opts, callb
  method: method,
  url: url,
  json: true
- }, opts), function onComplete(err, res, body) {
+ }, this._requestParams, opts), function onComplete(err, res, body) {
  if (err) {
  return callback && callback(err);
  }

diff --git a/test/webhdfs.js b/test/webhdfs.js
@@ -231,11 +231,37 @@ describe('WebHDFS with requestParams', function() {
 
  remoteFileStream.on('response', function(response) {
  var customHeader = response.req.getHeader('X-My-Custom-Header');
- demand(customHeader).equal('Kerberos')
+ demand(customHeader).equal('Kerberos');
  demand(spy.called).be.falsy();
  done();
  })
 
  });
 
+ it('should pass requestParams to _sendRequest', function (done) {
+ var req = hdfs.readdir('/');
+
+ req.on('response', function(response) {
+ var customHeader = response.req.getHeader('X-My-Custom-Header');
+ demand(customHeader).equal('Kerberos');
+ done();
+ });
+ });
+
+ it('should not override explicit opts with _sendRequest', function (done) {
+ var mostSpecificParams = {
+ headers: {
+ 'X-My-Custom-Header': 'Bear'
+ }
+ }
+
+ var endpoint = hdfs._getOperationEndpoint('liststatus', '/file-2');
+
+ hdfs._sendRequest('GET', endpoint, mostSpecificParams, function(err, response, body) {
+ var customHeader = response.req.getHeader('X-My-Custom-Header');
+ demand(customHeader).equal('Bear');
+ done(err)
+ });
+ });
+
 });