Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the functionality to get the total time spent by the user in a session #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ymaheshwari1
Copy link
Contributor

Fixes: #140

Proposed Changes

To find the time the user spent on the site in a session

@harsh7in harsh7in requested a review from Kajol-Kumari October 2, 2020 15:46
Copy link
Collaborator

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymaheshwari1 functionality looks fine but may I get a demo of where we are actually using this calculated time spend by the user during a session?

@ymaheshwari1
Copy link
Contributor Author

@Kajol-Kumari Currently I am just logging the session time. I am not showing it to the user.
Also, the functionality will help to determine the time spent which will be used in the statistics.
@harsh-9in Provide your input as well for this.

Copy link
Collaborator

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality LGTM 👍

But would like know how we are going to use it for showing stats :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Count
2 participants