[Cypress] Fix failed test on v1.4.0 for the dashboard string changes #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgildersleeve
requested changes
Oct 16, 2024
Comment on lines
70
to
75
| type: 'S3', | ||
| endpoint: "http://172.19.99.205:9000", | ||
| bucketName: "cypress", | ||
| bucketRegion: "ecmlab", | ||
| accessKeyId: "minioadmin", | ||
| secretAccessKey: "minioadmin", |
There was a problem hiding this comment.
This looks like you hardcoded in some stuff instead of grabbing from the config/env file. You should change that.
There was a problem hiding this comment.
Thanks for the check.
I have change back the S3 backup target setting.
Since we are migrating test environment to the new lab machines. I thinks it would be better to create a new PR to handle with S3 backup testcases along with the new minio settings.
|
@TachunLin you should also squash your commits before the PR merge. |
TachunLin
force-pushed
the
cypress-140-string-fix
branch
from
a22ae3d
to
5d505ca
Compare
TachunLin
force-pushed
the
cypress-140-string-fix
branch
from
be8e2e2
to
fb04229
Compare
|
I just S3 backup target in the settings/setting.spec.ts and squash the commit. |
TachunLin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Harvester issue: harvester/harvester#6407
Test sssue: #1535
What this PR does / why we need it:
Starting with v1.4.0, we have made some dashboard string changes in issue [BUG] UI Improvements: Language and consistency harvester#6407
This change would cause cypress test to have around
46failure result job #110The corresponding test result:
Special notes for your reviewer:
Tested on the latest
v1.4.0-rc1cypress test result on Jenkins Harvester cypress test job # 114According to the corresponding cypress test report
After the fix, the failed test reduced from
46to9