Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update email template #449

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

update email template #449

wants to merge 9 commits into from

Conversation

StephanieBr
Copy link

screen shot 2018-05-23 at 1 59 44 pm

Button is now in a table since it breaks in outlook otherwise.

@vidya-ram vidya-ram requested review from jace and iambibhas May 23, 2018 13:08
@StephanieBr StephanieBr changed the title Email template wip Placed button inside tables for Outlook client May 23, 2018
@StephanieBr StephanieBr changed the title Placed button inside tables for Outlook client update email template May 23, 2018
Copy link
Member

@jace jace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all right, but I'll need to see the sample email in my inbox to judge properly. Does someone have this in a development instance?

@jace
Copy link
Member

jace commented Jun 25, 2018

I'm waiting on sample emails to proceed with the review.

@jace
Copy link
Member

jace commented Jun 26, 2018

screenshot_20180626-225950

There is too much whitespace in this template.

@vidya-ram
Copy link
Member

vidya-ram commented Jun 29, 2018

Fixed the width of the wrapper and content box

@CLAassistant
Copy link

CLAassistant commented May 16, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ vidya-ram
❌ Stephanie Br


Stephanie Br seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants